Reformulate point_at_expr_source_of_inferred_type to be more accurate
#108687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Mar 3, 2023
compiler-errors
commented
Mar 3, 2023
|
☔ The latest upstream changes (presumably #108707) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
reformulate-point_at_expr_source_of_inferred_type
branch
from
b4d7750
to
9d23826
Compare
|
☔ The latest upstream changes (presumably #109762) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
reformulate-point_at_expr_source_of_inferred_type
branch
from
9d23826
to
3bb0f3c
Compare
|
☔ The latest upstream changes (presumably #110249) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-cloud-vms
bot
force-pushed
the
reformulate-point_at_expr_source_of_inferred_type
branch
2 times, most recently
from
7f340bf
to
5cc4757
Compare
|
It's been more than a month without review. r? compiler |
|
Lol I should not have reviewed commit-by-commit. Everything I noticed was fixed later. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108687 (Reformulate `point_at_expr_source_of_inferred_type` to be more accurate) - rust-lang#109272 (Add Command environment variable inheritance docs) - rust-lang#109947 (Add links from `core::cmp` derives to their traits) - rust-lang#110110 (Use `Display` in top-level example for `PanicInfo`) - rust-lang#110154 (Fix typos in library) - rust-lang#110244 (Remove some unneeded imports / qualified paths) - rust-lang#110328 ([rustdoc] Add explanations for auto-disambiguation when an intra doc link is resolved to a proc-macro and a trait at the same time) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
deleted the
reformulate-point_at_expr_source_of_inferred_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more accurate when deducing where along the several usages of a binding it is constrained to be some type that is incompatible with an expectation.
This also renames the method to
note_source_of_type_mismatch_constraintbecause I prefer that name, though I guess I can revert that. (Also drive-by renamenote_result_coercion->suggest_coercing_result_via_try_operator, because it's suggesting, not noting!)This PR is (probably?) best reviewed per commit, but it does regress a bit only to fix it later on, so it could also be reviewed as a whole if that makes the final results more clear.
r? @estebank