Change text -> rust highlighting in sanitizer.md #108997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
@rustbot label +A-docs |
rustbot
added
the
A-docs
JohnTitor
approved these changes
Mar 11, 2023
|
Good catch, thanks! Maybe a copy/paste error? |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2023
Change text -> rust highlighting in sanitizer.md Not sure why this has syntax highlighting turned off, but it doesn't need to be Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
bors
added
S-waiting-on-author
|
I'm a bit confused - the rollup failure looks like a curl issue downloading llvm? I can't see this PR making a difference there |
|
Yeah, this just changes the annotation on the unstable book, @matthiaskrgr why do you think it's related? |
|
Ah sorry, my bad, let's retry then 🙂 |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 13, 2023
Change text -> rust highlighting in sanitizer.md Not sure why this has syntax highlighting turned off, but it doesn't need to be Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
|
Ah sorry, still failing. Apparently I linked the wrong stacktrace https://github.com/rust-lang-ci/rust/actions/runs/4409005246/jobs/7724759124 @bors r- |
bors
added
S-waiting-on-author
|
Oh whoops, thanks for pointing that out. I'll update this in a minute |
|
Awesome, thank you! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 16, 2023
Change text -> rust highlighting in sanitizer.md Not sure why this has syntax highlighting turned off, but it doesn't need to be Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
bors
added
S-waiting-on-author
|
Wow, didn’t expect this tiny PR to be that annoying. I’ll just mark the doctest ignore when I get the chance. |
|
well, you may have found the reason why the highlighting was turned off 🙃 |
|
What a complicated world assembly is! r=me once it's fixed, @bors delegate+ |
|
✌️ @tgross35 can now approve this pull request |
Marked ignore due to difficulty getting doctests to pass cross-platform
|
Thanks for the power, but I can't figure out a good way to get the output tests to work cross-platform. So I'll just mark it ignore and call it a day :) @bors r=JohnTitor rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 22, 2023
Change text -> rust highlighting in sanitizer.md Not sure why this has syntax highlighting turned off, but it doesn't need to be Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2023
Rollup of 11 pull requests Successful merges: - rust-lang#100311 (Fix handling of trailing bare CR in str::lines) - rust-lang#108997 (Change text -> rust highlighting in sanitizer.md) - rust-lang#109179 (move Option::as_slice to intrinsic) - rust-lang#109187 (Render source page layout with Askama) - rust-lang#109280 (Remove `VecMap`) - rust-lang#109295 (refactor `fn bootstrap::builder::Builder::compiler_for` logic) - rust-lang#109312 (rustdoc: Cleanup parent module tracking for doc links) - rust-lang#109317 (Update links for custom discriminants.) - rust-lang#109405 (RPITITs are `DefKind::Opaque` with new lowering strategy) - rust-lang#109414 (Do not consider synthesized RPITITs on missing items checks) - rust-lang#109435 (Detect uninhabited types early in const eval) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this has syntax highlighting turned off, but it doesn't need to be
Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html