Rollup of 13 pull requests #109376
Merged
Rollup of 13 pull requests #109376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it's one of the biggest sections.
This tweak to the function signature search engine makes things so that, if a type is repeated in the search query, it'll only match if the function actually includes it that many times.
…s, r=spastorino Update names/comments for new return-position impl trait in trait lowering strategy r? `@spastorino` totally cosmetic
…-inlining, r=notriddle rustdoc: Fix missing private inlining Fixes rust-lang#109258. If the item isn't inlined, it shouldn't have been added into `view_item_stack`. The problem here was that it was not removed, preventing sub items to be inlined if they have a re-export in "upper levels". cc `@epage` r? `@notriddle`
rustdoc: cleanup some intermediate allocs First commit self contained, second one use `display_fn` for `extra_info_tags`
fix: fix ICE in `custom-test-frameworks` feature Fixes rust-lang#107454 Simple fix to emit error instead of ICEing. At some point, all the code in `tests.rs` should be refactored, there is a bit of duplication (this PR's code is repeated five times over lol). r? `@Nilstrieb` (active on the linked issue?)
…=notriddle Add test for `c_variadic` in rustdoc-json Helps with rust-lang#81359
…anonur Ignore files in .gitignore in mir opt check This caused `./x test tidy` to fail for me when Finder (macOS) added `.DS_Store` files. They are ignored by git, so tidy should ignore them, too.
…antics, r=GuillaumeGomez rustdoc: implement bag semantics for function parameter search This tweak to the function signature search engine makes things so that, if a type is repeated in the search query, it'll only match if the function actually includes it that many times.
Improve `Iterator::collect_into` documentation This improves the examples in the documentation of `Iterator::collect_into`, replacing the usages of `println!` with `assert_eq!` as suggested on [IRLO](https://internals.rust-lang.org/t/18534/9).
…ary, r=notriddle rustdoc: Remove footnote references from doc summary Since it's one line, we don't have the footnote definition so it doesn't make sense to have the reference. Part of rust-lang#109024. r? `@notriddle`
…mpiler-errors Fix wrong crate name in custom MIR docs
…, r=bjorn3 Split `items` from `-Zmeta-stats` in two. Because it's one of the biggest sections. r? `@bjorn3`
fix ClashingExternDeclarations lint ICE Fixes rust-lang#109334 First "real" contribution, please let me know if I did something wrong. As I understand it, it's OK if a `#[repr(transparent)]` type has no non-zero sized types (aka is a ZST itself) and the function should just return the type normally instead of panicking r? `@Nilstrieb`
… r=jsha rustdoc: Fix improper escaping of deprecation reasons Fix rust-lang#109374 r? `@jsha`
rustbot
added
A-rustdoc-json
|
@bors r+ rollup=never p=13 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 9d0eac4d02 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 20, 2023
|
Finished benchmarking commit (e91364b): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
custom-test-frameworksfeature #109301 (fix: fix ICE incustom-test-frameworksfeature)c_variadicin rustdoc-json #109319 (Add test forc_variadicin rustdoc-json)Iterator::collect_intodocumentation #109337 (ImproveIterator::collect_intodocumentation)itemsfrom-Zmeta-statsin two. #109362 (Splititemsfrom-Zmeta-statsin two.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup