Report allocation errors as panics #109507

Amanieu · 2023-03-23T00:40:32Z

OOM is now reported as a panic but with a custom payload type (AllocErrorPanicPayload) which holds the layout that was passed to handle_alloc_error.

This should be review one commit at a time:

The first commit adds AllocErrorPanicPayload and changes allocation errors to always be reported as panics.
The second commit removes #[alloc_error_handler] and the alloc_error_hook API.

ACP: rust-lang/libs-team#192

Closes #51540
Closes #51245

rustbot · 2023-03-23T00:40:39Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-03-23T00:40:42Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

bors · 2023-03-23T10:29:28Z

☔ The latest upstream changes (presumably #109503) made this pull request unmergeable. Please resolve the merge conflicts.

library/alloc/src/alloc.rs

compiler/rustc_feature/src/removed.rs

davidtwco

LGTM, r=me if you're just waiting on reviewer

Amanieu · 2023-03-28T14:31:31Z

Currently blocked on this FCP.

Amanieu · 2023-04-16T18:48:43Z

FCP is complete, this is now ready to merge.

davidtwco · 2023-04-17T11:01:27Z

@bors r+

This was missed in rust-lang#109507.

Manishearth · 2023-04-23T17:33:02Z

I've opened #110733

format panic message only once For `panic!` and friends, the `std` panic runtime will always set the `.payload()` of `PanicInfo` to the formatted string. The linked issues show that formatting the message twice can cause problems, so we simply print the already formatted message instead of formatting it again. We can't remove the preformatted payload, because it can be observed by custom panic hooks. fixes rust-lang#110717 fixes rust-itertools/itertools#694 cc `@Amanieu` who broke this in rust-lang#109507

format panic message only once For `panic!` and friends, the `std` panic runtime will always set the `.payload()` of `PanicInfo` to the formatted string. The linked issues show that formatting the message twice can cause problems, so we simply print the already formatted message instead of formatting it again. We can't remove the preformatted payload, because it can be observed by custom panic hooks. fixes rust-lang#110717 fixes rust-itertools/itertools#694 cc ``@Amanieu`` who broke this in rust-lang#109507

See rust-lang/rust#109507

format panic message only once For `panic!` and friends, the `std` panic runtime will always set the `.payload()` of `PanicInfo` to the formatted string. The linked issues show that formatting the message twice can cause problems, so we simply print the already formatted message instead of formatting it again. We can't remove the preformatted payload, because it can be observed by custom panic hooks. fixes rust-lang#110717 fixes rust-itertools/itertools#694 cc ```@Amanieu``` who broke this in rust-lang#109507

…manieu Revert panic oom This temporarily reverts rust-lang#109507 until rust-lang#110771 is addressed r? `@Amanieu`

…milio The new API landed in rust-lang/rust#109507 Differential Revision: https://phabricator.services.mozilla.com/D176383

format panic message only once Formatting the panic message multiple times can cause problems for some real-world crates, so here's a test to ensure that we don't do that. This was regressed in rust-lang#109507 and reverted in rust-lang#110782. fixes rust-lang#110717 fixes rust-itertools/itertools#694

Report allocation errors as panics OOM is now reported as a panic but with a custom payload type (`AllocErrorPanicPayload`) which holds the layout that was passed to `handle_alloc_error`. This should be review one commit at a time: - The first commit adds `AllocErrorPanicPayload` and changes allocation errors to always be reported as panics. - The second commit removes `#[alloc_error_handler]` and the `alloc_error_hook` API. ACP: rust-lang/libs-team#192 Closes rust-lang#51540 Closes rust-lang#51245

…milio The new API landed in rust-lang/rust#109507 Differential Revision: https://phabricator.services.mozilla.com/D176383 UltraBlame original commit: 04bb12c2c8fd7036f9f2d0b85a73c6cb31b0dcf0

Report allocation errors as panics OOM is now reported as a panic but with a custom payload type (`AllocErrorPanicPayload`) which holds the layout that was passed to `handle_alloc_error`. This should be review one commit at a time: - The first commit adds `AllocErrorPanicPayload` and changes allocation errors to always be reported as panics. - The second commit removes `#[alloc_error_handler]` and the `alloc_error_hook` API. ACP: rust-lang/libs-team#192 Closes rust-lang#51540 Closes rust-lang#51245

Revert panic oom This temporarily reverts rust-lang/rust#109507 until rust-lang/rust#110771 is addressed r? `@Amanieu`

See rust-lang/rust#109507

rustbot assigned davidtwco Mar 23, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 23, 2023

This comment has been minimized.

Sign in to view

Sheylas1 approved these changes Mar 23, 2023

View reviewed changes

Amanieu added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Mar 23, 2023

Amanieu force-pushed the panic-oom-payload branch from d50da58 to ccad895 Compare March 23, 2023 00:50

Amanieu mentioned this pull request Mar 23, 2023

Tracking issue for the #[alloc_error_handler] attribute (for no_std + liballoc) #51540

Open

2 tasks

This comment has been minimized.

Sign in to view

lnicola approved these changes Mar 23, 2023

View reviewed changes

RalfJung reviewed Mar 23, 2023

View reviewed changes

library/alloc/src/alloc.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Mar 23, 2023

View reviewed changes

compiler/rustc_feature/src/removed.rs Outdated Show resolved Hide resolved

Amanieu force-pushed the panic-oom-payload branch from 04025a1 to 7cdaf6e Compare March 23, 2023 23:14

This comment has been minimized.

Sign in to view

davidtwco approved these changes Mar 28, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

Amanieu added 2 commits April 16, 2023 08:35

Report allocation errors as panics

c9a6e41

Remove #[alloc_error_handler] from the compiler and library

abc0660

Amanieu force-pushed the panic-oom-payload branch from 8511a3f to 2355a4a Compare April 16, 2023 15:36

Amanieu removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Apr 16, 2023

Rename -Zoom=panic to -Zoom=unwind

4b981c2

Amanieu force-pushed the panic-oom-payload branch from 2355a4a to 4b981c2 Compare April 16, 2023 18:50

Amanieu added a commit to Amanieu/rust that referenced this pull request Apr 23, 2023

Add tracking issue for panic_oom_payload

8093b63

This was missed in rust-lang#109507.

Amanieu mentioned this pull request Apr 23, 2023

Add tracking issue for panic_oom_payload #110731

Closed

Manishearth mentioned this pull request Apr 23, 2023

Reintroduce alloc_error_handler as deprecated #110733

Closed

equation314 added a commit to arceos-org/arceos that referenced this pull request Apr 24, 2023

Remove #[alloc_error_handler], fix nightly build

baa1a83

See rust-lang/rust#109507

This was referenced Apr 24, 2023

rustc hangs after ICEing due to memory limit #110771

Closed

Revert panic oom #110782

Merged

phil-opp mentioned this pull request Apr 29, 2023

The #[alloc_error_handler] attribute was removed phil-opp/blog_os#1216

Merged

Amanieu mentioned this pull request Jun 5, 2023

Report allocation errors as panics, second attempt #112331

Open

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jul 18, 2023

Rollup merge of #110782 - matthiaskrgr:revert_panic_oom, r=Amanieu

4cd1211

Revert panic oom This temporarily reverts rust-lang/rust#109507 until rust-lang/rust#110771 is addressed r? `@Amanieu`

SimonSapin mentioned this pull request Dec 9, 2023

Tracking issue for the OOM hook (alloc_error_hook) #51245

Open

5 tasks

cutecutecat mentioned this pull request Jan 5, 2024

chore: friendly OOM message tensorchord/pgvecto.rs#223

Merged

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024

Rollup merge of #110782 - matthiaskrgr:revert_panic_oom, r=Amanieu

e9e3ea1

Revert panic oom This temporarily reverts rust-lang/rust#109507 until rust-lang/rust#110771 is addressed r? `@Amanieu`

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024

Rollup merge of #110782 - matthiaskrgr:revert_panic_oom, r=Amanieu

af9f00d

Revert panic oom This temporarily reverts rust-lang/rust#109507 until rust-lang/rust#110771 is addressed r? `@Amanieu`

Azure-stars pushed a commit to Starry-OS/axalloc that referenced this pull request May 1, 2024

Remove #[alloc_error_handler], fix nightly build

84f5848

See rust-lang/rust#109507

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report allocation errors as panics #109507

Report allocation errors as panics #109507

Amanieu commented Mar 23, 2023

rustbot commented Mar 23, 2023

rustbot commented Mar 23, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Mar 23, 2023

This comment has been minimized.

This comment has been minimized.

davidtwco left a comment

Amanieu commented Mar 28, 2023

This comment was marked as resolved.

Amanieu commented Apr 16, 2023

davidtwco commented Apr 17, 2023

Manishearth commented Apr 23, 2023

Report allocation errors as panics #109507

Report allocation errors as panics #109507

Conversation

Amanieu commented Mar 23, 2023

rustbot commented Mar 23, 2023

rustbot commented Mar 23, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Mar 23, 2023

This comment has been minimized.

This comment has been minimized.

davidtwco left a comment

Choose a reason for hiding this comment

Amanieu commented Mar 28, 2023

This comment was marked as resolved.

Amanieu commented Apr 16, 2023

davidtwco commented Apr 17, 2023

Manishearth commented Apr 23, 2023