Replace rustdoc-ui/{c,z}-help tests with a stable run-make test #109810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
jyn514
commented
Mar 31, 2023
| @@ -398,6 +398,8 @@ fn run_test( | |||
| compiler.stdin(Stdio::piped()); | |||
| compiler.stderr(Stdio::piped()); | |||
|
|
|||
| debug!("compiler invocation for doctest: {:?}", compiler); | |||
There was a problem hiding this comment.
I added this so I could double check that -C ... flags are passed through to the compiler when running doctests.
jyn514
force-pushed
the
rustdoc-opt-tests
branch
from
234f3c5
to
72ea377
Compare
|
☔ The latest upstream changes (presumably #109808) made this pull request unmergeable. Please resolve the merge conflicts. |
jyn514
force-pushed
the
rustdoc-opt-tests
branch
from
72ea377
to
876615e
Compare
|
This PR bitrots quickly; I'm not planning to rebase it until I get an initial review. |
TaKO8Ki
approved these changes
Apr 12, 2023
Before, rustdoc was missing `-C passes=list` and the "Available options" header. Making these match allows testing that they match exactly.
jyn514
force-pushed
the
rustdoc-opt-tests
branch
from
876615e
to
a25749e
Compare
|
Sure thing, done :) @bors r=TaKO8Ki |
|
📌 Commit a25749e17e2ccb3a8c21df580303a4ca85ae20b6 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This make rustdoc resilient to changes in the debugging options while still testing that it matches rustc.
jyn514
force-pushed
the
rustdoc-opt-tests
branch
from
a25749e
to
67b3919
Compare
|
@bors r- r=TaKO8Ki |
bors
added
S-waiting-on-author
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109810 (Replace rustdoc-ui/{c,z}-help tests with a stable run-make test ) - rust-lang#110035 (fix: ensure bad `#[test]` invocs retain correct AST) - rust-lang#110089 (sync::mpsc: synchronize receiver disconnect with initialization) - rust-lang#110103 (Report overflows gracefully with new solver) - rust-lang#110122 (Fix x check --stage 1 when download-ci-llvm=false) - rust-lang#110133 (Do not use ImplDerivedObligationCause for inherent impl method error reporting) - rust-lang#110135 (Revert "Don't recover lifetimes/labels containing emojis as character literals") - rust-lang#110235 (Fix `--extend-css` option) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make rustdoc resilient to changes in the debugging options while still testing that it matches rustc.
Fixes #109391.