Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some clippy fixes in the compiler #110124

Merged
merged 16 commits into from
Apr 10, 2023
Merged

Some clippy fixes in the compiler #110124

merged 16 commits into from
Apr 10, 2023

Commits on Apr 9, 2023

  1. Some simple clippy::perf fixes

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    f058d05 View commit details
    Browse the repository at this point in the history

  2. Use HashMap entry APIs more

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    54e1309 View commit details
    Browse the repository at this point in the history

  3. Box large enum variants

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    f00366d View commit details
    Browse the repository at this point in the history

  4. Allow clippy::from_mut_ref 

    This pattern is fine for arena allocators.
    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    968be98 View commit details
    Browse the repository at this point in the history

  5. Allow modulo_one on function using cfg consts

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    0a0968b View commit details
    Browse the repository at this point in the history

  6. Small clippy::correctness fixes 

    Nothing was really incorrect before, but it did get nicer.
    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    07cd382 View commit details
    Browse the repository at this point in the history

  7. Properly compare previously shadowed values 

    The shadowing lead to an incorrect comparison. Rename it and compare it
properly. compiler-errors told me that I should just include the fix
here without a test.
    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    1c75724 View commit details
    Browse the repository at this point in the history

  8. Delete useless loop

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    5a90de8 View commit details
    Browse the repository at this point in the history

  9. Improve `Allocation::hash 

    Exhaustively destructure and ignore `()`
    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    6fceb0f View commit details
    Browse the repository at this point in the history

  10. Fix some clippy::complexity

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    81c320e View commit details
    Browse the repository at this point in the history

  11. Remove identity casts

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    4b4948c View commit details
    Browse the repository at this point in the history

  12. Convert manual loop into while let

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    e5defd0 View commit details
    Browse the repository at this point in the history

  13. Simply Abi::fmt

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    5853c28 View commit details
    Browse the repository at this point in the history

  14. fixup! Improve `Allocation::hash

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    cab94d2 View commit details
    Browse the repository at this point in the history

  15. Inline format_args 

    Co-authored-by: Michael Goulet <michael@errs.io>
    @Noratrieb @compiler-errors
    Noratrieb and compiler-errors authored Apr 9, 2023
    Configuration menu
    Copy the full SHA
    73417b1 View commit details
    Browse the repository at this point in the history

  16. Remove turbofish

    @Noratrieb
    Noratrieb committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    9fc1555 View commit details
    Browse the repository at this point in the history