Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable hash tag (discriminant) of GenericArg #110622

Merged
merged 1 commit into from Apr 22, 2023
Merged

Stable hash tag (discriminant) of GenericArg #110622

merged 1 commit into from Apr 22, 2023

Conversation

WaffleLapkin
Copy link
Member

This is a continuation of my quest of removing transmute if generic args and types (#110496, #110599).

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2023
@cjgillot
Copy link
Contributor

Could we replace this impl by a derive?

@compiler-errors
Copy link
Member

Yeah, we probably can do instead.

@WaffleLapkin
Copy link
Member Author

Looks like we can indeed.

@compiler-errors
Copy link
Member

squash then r=me

@WaffleLapkin
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Apr 20, 2023

📌 Commit 4375af5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2023
@bors
Auto merge of rust-lang#110666 - JohnTitor:rollup-3pwilte, r=JohnTitor
3128fd8 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#109949 (rustdoc: migrate `document_type_layout` to askama)
 - rust-lang#110622 (Stable hash tag (discriminant) of `GenericArg`)
 - rust-lang#110635 (More `IS_ZST` in `library`)
 - rust-lang#110640 (compiler/rustc_target: Raise m68k-linux-gnu baseline to 68020)
 - rust-lang#110657 (nit: consistent naming for SimplifyConstCondition)
 - rust-lang#110659 (rustdoc: clean up JS)
 - rust-lang#110660 (Print ty placeholders pretty)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9a798e4 into rust-lang:master Apr 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.71.0 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WaffleLapkin @cjgillot @compiler-errors @bors @rustbot