-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass unused_extern_crates
in librustdoc::doctest::make_test
#110798
pass unused_extern_crates
in librustdoc::doctest::make_test
#110798
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Can you add the reasoning behind allowing this in the comment? It doesn't explain why rustdoc should do this. |
This comment has been minimized.
This comment has been minimized.
This is needed for using ref err: https://github.com/rust-lang/rust/actions/runs/4797403514/jobs/8534349146?pr=106621#step:26:3011 will extend the comment, I guess it's not clear enough. |
0e71a87
to
ca118d4
Compare
It still doesn't include reasoning why rustdoc should pass this by default. Why is not allowing it a problem? |
We want to add Because of this line https://github.com/rust-lang/rust/blob/ca118d4f3e1366dee7a51a3177a2e82d9007f0a8/src/librustdoc/doctest.rs#L686 adds lines like |
"rustdoc implicitly inserts an |
Signed-off-by: ozkanonur <work@onurozkan.dev>
ca118d4
to
f56b6d0
Compare
@bors r+ rollup |
…ates, r=jyn514 pass `unused_extern_crates` in `librustdoc::doctest::make_test` blocker for rust-lang#106621
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#108760 (Add lint to deny diagnostics composed of static strings) - rust-lang#109444 (Change tidy error message for TODOs) - rust-lang#110419 (Spelling library) - rust-lang#110550 (Suggest deref on comparison binop RHS even if type is not Copy) - rust-lang#110641 (Add new rustdoc book chapter to describe in-doc settings) - rust-lang#110798 (pass `unused_extern_crates` in `librustdoc::doctest::make_test`) - rust-lang#110819 (simplify TrustedLen impls) - rust-lang#110825 (diagnostics: add test case for already-solved issue) - rust-lang#110835 (Make some region folders a little stricter.) - rust-lang#110847 (rustdoc-json: Time serialization.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
blocker for #106621