-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #111089
Rollup of 7 pull requests #111089
Commits on Mar 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 05c1e6b - Browse repository at this point
Copy the full SHA 05c1e6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c34f77 - Browse repository at this point
Copy the full SHA 5c34f77View commit details
Commits on Apr 5, 2023
-
Refactor core::char::EscapeDefault and co. structures
Change core::char::{EscapeUnicode, EscapeDefault and EscapeDebug} structures from using a state machine to computing escaped sequence upfront and during iteration just going through the characters. This is arguably simpler since it’s easier to think about having a buffer and start..end range to iterate over rather than thinking about a state machine. This also harmonises implementation of aforementioned iterators and core::ascii::EscapeDefault struct. This is done by introducing a new helper EscapeIterInner struct which holds the buffer and offers simple methods for iterating over range. As a side effect, this probably optimises Display implementation for those types since rather than calling write_char repeatedly, write_str is invoked once. On 64-bit platforms, it also reduces size of some of the structs: | Struct | Before | After | |----------------------------+--------+-------+ | core::char::EscapeUnicode | 16 | 12 | | core::char::EscapeDefault | 16 | 12 | | core::char::EscapeDebug | 16 | 16 | My ulterior motive and reason why I started looking into this is addition of as_str method to the iterators. With this change this will became trivial. It’s also going to be trivial to implement DoubleEndedIterator if that’s ever desired.
Configuration menu - View commit details
-
Copy full SHA for 4510439 - Browse repository at this point
Copy the full SHA 4510439View commit details
Commits on Apr 27, 2023
-
Remove all in target_thread_local cfg
I think it was left there by mistake after previous refactoring. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be413ae - Browse repository at this point
Copy the full SHA be413aeView commit details -
Implement
StructuralEq
for integers,bool
andchar
(how did this work before??)
Configuration menu - View commit details
-
Copy full SHA for 518d348 - Browse repository at this point
Copy the full SHA 518d348View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a716da - Browse repository at this point
Copy the full SHA 9a716daView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8844e1 - Browse repository at this point
Copy the full SHA c8844e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81a2b85 - Browse repository at this point
Copy the full SHA 81a2b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for c45c4f2 - Browse repository at this point
Copy the full SHA c45c4f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c54410 - Browse repository at this point
Copy the full SHA 1c54410View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7234d63 - Browse repository at this point
Copy the full SHA 7234d63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2205c3f - Browse repository at this point
Copy the full SHA 2205c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bf6bbb - Browse repository at this point
Copy the full SHA 1bf6bbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c5e716 - Browse repository at this point
Copy the full SHA 2c5e716View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51355ad - Browse repository at this point
Copy the full SHA 51355adView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdb5502 - Browse repository at this point
Copy the full SHA bdb5502View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26417a8 - Browse repository at this point
Copy the full SHA 26417a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f70d02 - Browse repository at this point
Copy the full SHA 2f70d02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f44a24 - Browse repository at this point
Copy the full SHA 1f44a24View commit details
Commits on Apr 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 182eee2 - Browse repository at this point
Copy the full SHA 182eee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c99175 - Browse repository at this point
Copy the full SHA 5c99175View commit details
Commits on Apr 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e928067 - Browse repository at this point
Copy the full SHA e928067View commit details -
Configuration menu - View commit details
-
Copy full SHA for 475378f - Browse repository at this point
Copy the full SHA 475378fView commit details
Commits on Apr 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d0f7e2 - Browse repository at this point
Copy the full SHA 4d0f7e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76c9947 - Browse repository at this point
Copy the full SHA 76c9947View commit details
Commits on May 1, 2023
-
Fix
StructuralEq
impls for&T
,[T]
and[T; N]
(`StructuralEq` is shallow for some reason...)
Configuration menu - View commit details
-
Copy full SHA for c317546 - Browse repository at this point
Copy the full SHA c317546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bcfff4 - Browse repository at this point
Copy the full SHA 0bcfff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea71f2 - Browse repository at this point
Copy the full SHA 8ea71f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bec7193 - Browse repository at this point
Copy the full SHA bec7193View commit details -
Configuration menu - View commit details
-
Copy full SHA for b00e5f3 - Browse repository at this point
Copy the full SHA b00e5f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9653a6 - Browse repository at this point
Copy the full SHA c9653a6View commit details
Commits on May 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7411468 - Browse repository at this point
Copy the full SHA 7411468View commit details -
Rollup merge of rust-lang#105076 - mina86:a, r=scottmcm
Refactor core::char::EscapeDefault and co. structures Change core::char::{EscapeUnicode, EscapeDefault and EscapeDebug} structures from using a state machine to computing escaped sequence upfront and during iteration just going through the characters. This is arguably simpler since it’s easier to think about having a buffer and start..end range to iterate over rather than thinking about a state machine. This also harmonises implementation of aforementioned iterators and core::ascii::EscapeDefault struct. This is done by introducing a new helper EscapeIterInner struct which holds the buffer and offers simple methods for iterating over range. As a side effect, this probably optimises Display implementation for those types since rather than calling write_char repeatedly, write_str is invoked once. On 64-bit platforms, it also reduces size of some of the structs: | Struct | Before | After | |----------------------------+--------+-------+ | core::char::EscapeUnicode | 16 | 12 | | core::char::EscapeDefault | 16 | 12 | | core::char::EscapeDebug | 16 | 16 | My ulterior motive and reason why I started looking into this is addition of as_str method to the iterators. With this change this will became trivial. It’s also going to be trivial to implement DoubleEndedIterator if that’s ever desired.
Configuration menu - View commit details
-
Copy full SHA for f916c44 - Browse repository at this point
Copy the full SHA f916c44View commit details -
Rollup merge of rust-lang#108161 - WaffleLapkin:const_param_ty, r=Box…
…yUwU Add `ConstParamTy` trait This is a bit sketch, but idk. r? `@BoxyUwU` Yet to be done: - [x] ~~Figure out if it's okay to implement `StructuralEq` for primitives / possibly remove their special casing~~ (it should be okay, but maybe not in this PR...) - [ ] Maybe refactor the code a little bit - [x] Use a macro to make impls a bit nicer Future work: - [ ] Actually™ use the trait when checking if a `const` generic type is allowed - [ ] _Really_ refactor the surrounding code - [ ] Refactor `marker.rs` into multiple modules for each "theme" of markers
Configuration menu - View commit details
-
Copy full SHA for b727132 - Browse repository at this point
Copy the full SHA b727132View commit details -
Rollup merge of rust-lang#108668 - gibbyfree:stabilizedebuggervisuali…
…zer, r=wesleywiser Stabilize debugger_visualizer This stabilizes the `debugger_visualizer` attribute (rust-lang#95939). * Marks the `debugger_visualizer` feature as `accepted`. * Marks the `debugger_visualizer` attribute as `ungated`. * Deletes feature gate test, removes feature gate from other tests. Closes rust-lang#95939
Configuration menu - View commit details
-
Copy full SHA for f379a58 - Browse repository at this point
Copy the full SHA f379a58View commit details -
Rollup merge of rust-lang#110512 - compiler-errors:fix-elaboration-wi…
…th-associated-type-bounds, r=spastorino Fix elaboration with associated type bounds When computing a trait's supertrait predicates, do not add any associated type *trait* bounds to that list of supertrait predicates. This is because supertrait predicates are expected to have the same `Self` type as the trait. For example, given: ```rust trait Foo: Bar<Assoc: Send> ``` Before, we would compute that the supertrait predicates of `T: Foo` are `T: Bar` and `<T as Bar>::Assoc: Send`. However, the last bound is a trait predicate for a totally different type than `T`, and existing code that uses supertrait bounds such as vtable construction, closure fn signature deduction, etc. all rely on the invariant that we have a list of predicates for self type `T`. Fixes rust-lang#76593 The reason for all the extra diagnostic noise is that we're recomputing predicates with a different filter now. These diagnostics should be deduplicated for any end-user though. --- This does bring up an interesting question -- is the predicate `<T as Bar>::Assoc: Send` an implied bound of `T: Foo`? Because currently the only bounds implied by a (non-alias) trait are its supertraits. I guess I could fix this too, but it would require even more changes, and I'm inclined to punt this question along.
Configuration menu - View commit details
-
Copy full SHA for be4f9f5 - Browse repository at this point
Copy the full SHA be4f9f5View commit details -
Rollup merge of rust-lang#110895 - Ayush1325:thread-local-fix, r=thomcc
Remove `all` in target_thread_local cfg I think it was left there by mistake after the previous refactoring. I just came across it while rebasing to master.
Configuration menu - View commit details
-
Copy full SHA for f47a63c - Browse repository at this point
Copy the full SHA f47a63cView commit details -
Rollup merge of rust-lang#110955 - fee1-dead-contrib:sus-operation, r…
…=compiler-errors uplift `clippy::clone_double_ref` as `suspicious_double_ref_op` Split from rust-lang#109842. r? ``@compiler-errors``
Configuration menu - View commit details
-
Copy full SHA for 40c4ed4 - Browse repository at this point
Copy the full SHA 40c4ed4View commit details -
Rollup merge of rust-lang#111048 - compiler-errors:rpitit-not-incompl…
…ete, r=jackh726 Mark`feature(return_position_impl_trait_in_trait)` and`feature(async_fn_in_trait)` as not incomplete I think they've graduated, since as far as I'm aware, they don't cause compiler crashes or unsoundness anymore.
Configuration menu - View commit details
-
Copy full SHA for 2e3373c - Browse repository at this point
Copy the full SHA 2e3373cView commit details