Mark ErrorGuaranteed constructor as deprecated so people don't use it
#111261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
May 5, 2023
compiler-errors
commented
May 5, 2023
| @@ -854,9 +854,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| let result = self | |||
| .resolve_fully_qualified_call(span, item_name, ty.normalized, qself.span, hir_id) | |||
| .or_else(|error| { | |||
| let guar = self | |||
There was a problem hiding this comment.
I'm pretty sure this is not introducing any ICEs, since we later error on bad privacy in type-dependent resolutions.
I think delaying a bug here would actually make sure we catch any subtle cases where private methods aren't being error'd correctly.
|
r=me if CI passes lol |
Nilstrieb
reviewed
May 5, 2023
Nilstrieb
reviewed
May 5, 2023
rust-cloud-vms
bot
force-pushed
the
error-guaranteed-should-be-scarier-to-construct
branch
from
0d2fcb7
to
6077fdd
Compare
|
@bors r=BoxyUwU |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#109677 (Stabilize raw-dylib, link_ordinal, import_name_type and -Cdlltool) - rust-lang#110780 (rustdoc-search: add slices and arrays to index) - rust-lang#110830 (Add FreeBSD cpuset support to `std::thread::available_concurrency`) - rust-lang#111139 (Fix MXCSR configuration dependent timing) - rust-lang#111239 (Remove unnecessary attribute from a diagnostic) - rust-lang#111246 (forbid escaping bound vars in combine) - rust-lang#111251 (Issue 109502 follow up, remove unnecessary Vec::new() from compile_test()) - rust-lang#111261 (Mark `ErrorGuaranteed` constructor as deprecated so people don't use it) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
deleted the
error-guaranteed-should-be-scarier-to-construct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should never ever ever ever ever ever ever ever ever ever ever ever ever ever ever ever ever use this function unless you know what you're doing, so make it harder to accidentally use it!
Alternatives are to change the name to sound scarier, make it
unsafe(though it's not really a soundness thing), or work on deeper refactors to make it private.r? @BoxyUwU