Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty_write since rust version attribute #114268

Merged
merged 1 commit into from Jul 31, 2023
Merged

Fix empty_write since rust version attribute #114268

merged 1 commit into from Jul 31, 2023

Conversation

SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Jul 30, 2023 •
edited

Fixup of #98154 for the rust version.

r? @workingjubilee

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2023
@SUPERCILEX SUPERCILEX changed the title feat: merge functionality of io::Sink into io::Empty Fix empty_write since rust version attribute Jul 30, 2023
@workingjubilee
Copy link
Contributor

Nice, thank you! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit 0b4a80f has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@workingjubilee workingjubilee mentioned this pull request Jul 31, 2023
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 31, 2023
@workingjubilee
Rollup merge of rust-lang#114268 - SUPERCILEX:empty, r=workingjubilee
9cda20a 
Fix empty_write since rust version attribute

Fixup of rust-lang#98154 for the rust version.

r? `@workingjubilee`
@workingjubilee workingjubilee mentioned this pull request Jul 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2023
@bors
Auto merge of rust-lang#114272 - workingjubilee:rollup-ll9lwon, r=wor…
dfc9d3f 
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#95965 (Stabilize const-weak-new)
 - rust-lang#109075 (Use `LazyLock` to lazily resolve backtraces)
 - rust-lang#113741 (Don't install default projection bound for return-position `impl Trait` in trait methods with no body)
 - rust-lang#114268 (Fix empty_write since rust version attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 495e657 into rust-lang:master Jul 31, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 31, 2023
@SUPERCILEX SUPERCILEX deleted the empty branch July 31, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SUPERCILEX @workingjubilee @bors @rustbot