Stabilize const-weak-new #95965

CAD97 · 2022-04-12T06:32:17Z

This is a fairly uncontroversial library stabilization, so I'm going ahead and proposing it to ride the trains to stable.

This stabilizes the following APIs, which are defined to be non-allocating constructors.

// alloc::rc
impl<T> Weak<T> {
    pub const fn new() -> Weak<T>;
}

// alloc::sync
impl<T> Weak<T> {
    pub const fn new() -> Weak<T>;
}

Closes #95091

@rustbot modify labels: +needs-fcp

rust-highfive · 2022-04-12T06:32:19Z

Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary

rust-highfive · 2022-04-12T06:32:21Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

CAD97 · 2022-04-12T06:32:45Z

r? rust-lang/libs-api @rustbot label +T-libs-api

CAD97 · 2022-06-22T03:19:35Z

(triaging my open PRs)

It's been a bit; attempting reviewer rotation. (I also need to bump the stabilized version; will do later.)

r? rust-lang/libs-api

Requesting I-libs-api-nominated T-libs-api nomination for FCP.

library/alloc/src/rc.rs

m-ou-se · 2022-06-22T13:33:18Z

@rfcbot merge

rfcbot · 2022-06-22T13:33:20Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

library/alloc/src/sync.rs

rfcbot · 2022-06-29T22:58:57Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2022-07-09T23:21:10Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

est31 · 2022-08-27T20:16:30Z

👋 Hello, I'm writing this comment in this stabilization PR to notify you, the authors of this PR, that #100591 has been merged, which implemented a change in how features are stabilized.

Your PR has been filed before the change, so will likely require modifications in order to comply with the new rules. I recommend you to:

rebase the PR onto latest master, so that uses of the placeholder are possible.
replace the version numbers in the PR with the placeholder CURRENT_RUSTC_VERSION. For language changes, this means the version numbers in accepted.rs (example: 4caedba). For library changes, this means the since fields (example e576a9b).

That's it! The CURRENT_RUSTC_VERSION placeholder will, as part of the release process, be replaced with the version number that the PR merged for. It can be used anywhere in rust-lang/rust, not just accepted.rs and the since fields.

If you have any questions, feel free to drop by the zulip stream, or ping me directly in this PR's thread. Thanks! 👋

ralismark · 2023-01-11T14:17:58Z

Just wondering, what's the situation with this PR? It seems ready to be merged (except for that last comment), but nothing has happened for a couple months now.

CAD97 · 2023-01-11T18:23:51Z

In theory it should get merged if I rebase it for the new process. (I had lost track of and forgotten that it was waiting on me for such.)

tgross35

Needed change for the new release process

library/alloc/src/rc.rs

library/alloc/src/sync.rs

tgross35 · 2023-03-09T21:33:19Z

@CAD97 I think my suggestion is the only change needed. Are you able to apply those and rebase soon? If not, I can do so and open a separate PR - but it's nicer to keep this together if you can.

pitaj · 2023-04-30T05:47:22Z

@CAD97 ping from triage. Can you get those stabilization changes detailed above implemented?

@rustbot author

tgross35 · 2023-05-17T15:02:47Z

It looks like @Dylan-DPC was able to apply my suggestions from above, so I believe this is ready for rereview/merge. @m-ou-se are you able to update the labels and/or merge?

pitaj · 2023-05-17T15:09:36Z

I believe this still needs a squash but it's ready for review regardless.

Bump its stabilization version several times along the way to accommodate changes in release processes. Co-authored-by: Mara Bos <m-ou.se@m-ou.se> Co-authored-by: Trevor Gross <t.gross35@gmail.com>

workingjubilee · 2023-07-31T00:08:31Z

crunch

workingjubilee · 2023-07-31T00:10:25Z

@bors r+ rollup

bors · 2023-07-31T00:10:27Z

📌 Commit ee29d2f has been approved by workingjubilee

It is now in the queue for this repository.

Stabilize const-weak-new This is a fairly uncontroversial library stabilization, so I'm going ahead and proposing it to ride the trains to stable. This stabilizes the following APIs, which are defined to be non-allocating constructors. ```rust // alloc::rc impl<T> Weak<T> { pub const fn new() -> Weak<T>; } // alloc::sync impl<T> Weak<T> { pub const fn new() -> Weak<T>; } ``` Closes rust-lang#95091 `@rustbot` modify labels: +needs-fcp

…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#95965 (Stabilize const-weak-new) - rust-lang#109075 (Use `LazyLock` to lazily resolve backtraces) - rust-lang#113741 (Don't install default projection bound for return-position `impl Trait` in trait methods with no body) - rust-lang#114268 (Fix empty_write since rust version attribute) r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned m-ou-se Apr 12, 2022

rustbot added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Apr 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 12, 2022

rust-highfive assigned joshtriplett and unassigned m-ou-se Apr 12, 2022

CAD97 mentioned this pull request Apr 12, 2022

Tracking Issue for const Weak::new #95091

Closed

3 tasks

m-ou-se reviewed Jun 22, 2022

View reviewed changes

library/alloc/src/rc.rs Outdated Show resolved Hide resolved

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 22, 2022

CAD97 commented Jun 22, 2022

View reviewed changes

library/alloc/src/sync.rs Outdated Show resolved Hide resolved

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jun 29, 2022

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 9, 2022

AldaronLau mentioned this pull request Aug 18, 2022

Route To 1.0.0 ardaku/whisk#22

Open

7 tasks

apiraino removed the to-announce Announce this issue on triage meeting label Sep 8, 2022

tgross35 reviewed Mar 9, 2023

View reviewed changes

library/alloc/src/rc.rs Outdated Show resolved Hide resolved

library/alloc/src/sync.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2023

rust-lang deleted a comment from rustbot May 12, 2023

pitaj added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2023

Stabilize const-weak-new

ee29d2f

Bump its stabilization version several times along the way to accommodate changes in release processes. Co-authored-by: Mara Bos <m-ou.se@m-ou.se> Co-authored-by: Trevor Gross <t.gross35@gmail.com>

workingjubilee force-pushed the const-weak-new branch from 8f2a068 to ee29d2f Compare July 31, 2023 00:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023

workingjubilee mentioned this pull request Jul 31, 2023

Rollup of 5 pull requests #114270

Closed

workingjubilee mentioned this pull request Jul 31, 2023

Rollup of 4 pull requests #114272

Merged

bors merged commit e5a6e5c into rust-lang:master Jul 31, 2023
11 checks passed

rustbot added this to the 1.73.0 milestone Jul 31, 2023

CAD97 deleted the const-weak-new branch November 6, 2023 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize const-weak-new #95965

Stabilize const-weak-new #95965

CAD97 commented Apr 12, 2022

rust-highfive commented Apr 12, 2022

rust-highfive commented Apr 12, 2022

CAD97 commented Apr 12, 2022

CAD97 commented Jun 22, 2022 •

edited

Loading

m-ou-se commented Jun 22, 2022

rfcbot commented Jun 22, 2022 •

edited by BurntSushi

Loading

rfcbot commented Jun 29, 2022

rfcbot commented Jul 9, 2022

est31 commented Aug 27, 2022

ralismark commented Jan 11, 2023

CAD97 commented Jan 11, 2023

tgross35 left a comment

tgross35 commented Mar 9, 2023

pitaj commented Apr 30, 2023

tgross35 commented May 17, 2023

pitaj commented May 17, 2023

workingjubilee commented Jul 31, 2023

workingjubilee commented Jul 31, 2023

bors commented Jul 31, 2023

Stabilize const-weak-new #95965

Stabilize const-weak-new #95965

Conversation

CAD97 commented Apr 12, 2022

rust-highfive commented Apr 12, 2022

rust-highfive commented Apr 12, 2022

CAD97 commented Apr 12, 2022

CAD97 commented Jun 22, 2022 • edited Loading

m-ou-se commented Jun 22, 2022

rfcbot commented Jun 22, 2022 • edited by BurntSushi Loading

rfcbot commented Jun 29, 2022

rfcbot commented Jul 9, 2022

est31 commented Aug 27, 2022

ralismark commented Jan 11, 2023

CAD97 commented Jan 11, 2023

tgross35 left a comment

Choose a reason for hiding this comment

tgross35 commented Mar 9, 2023

pitaj commented Apr 30, 2023

tgross35 commented May 17, 2023

pitaj commented May 17, 2023

workingjubilee commented Jul 31, 2023

workingjubilee commented Jul 31, 2023

bors commented Jul 31, 2023

CAD97 commented Jun 22, 2022 •

edited

Loading

rfcbot commented Jun 22, 2022 •

edited by BurntSushi

Loading