Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize thread local cell methods. #114689

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Stabilize thread local cell methods. #114689

merged 1 commit into from
Aug 16, 2023

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Aug 10, 2023 •
edited
Loading

Closes #92122.

@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Aug 10, 2023
@m-ou-se m-ou-se self-assigned this Aug 10, 2023
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2023
@m-ou-se m-ou-se mentioned this pull request Aug 10, 2023
Closed
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se force-pushed the stabilize-thread-local-cell-methods branch from 3999700 to dc3cbc1 Compare August 10, 2023 15:34
@m-ou-se m-ou-se marked this pull request as ready for review August 15, 2023 13:03
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

The Miri subtree was changed

cc @rust-lang/miri

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@m-ou-se
Copy link
Member Author

m-ou-se commented Aug 15, 2023

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned m-ou-se Aug 15, 2023
@thomcc
Copy link
Member

thomcc commented Aug 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 15, 2023

📌 Commit dc3cbc1 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@m-ou-se m-ou-se assigned thomcc and unassigned Amanieu Aug 15, 2023
@bors
Copy link
Contributor

bors commented Aug 16, 2023

⌛ Testing commit dc3cbc1 with merge 656ee47...

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 656ee47 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2023
@bors bors merged commit 656ee47 into rust-lang:master Aug 16, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (656ee47): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.559s -> 636.234s (0.26%)
Artifact size: 346.80 MiB -> 346.89 MiB (0.03%)

@m-ou-se m-ou-se deleted the stabilize-thread-local-cell-methods branch August 16, 2023 07:21
gendx added a commit to gendx/stv-rs that referenced this pull request Sep 29, 2023
@gendx
Migrate tests to Rust nightly 1.73.
e185203 
Upstream changes:
- "Stabilize thread local cell methods." rust-lang/rust#114689
- "Cleaner assert_eq! & assert_ne! panic messages" rust-lang/rust#111071
@chenrui333 chenrui333 mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for thread local Cell methods
7 participants
@m-ou-se @rust-log-analyzer @rustbot @thomcc @bors @rust-timer @Amanieu