Fix a pthread_t handle leak #114610 #114696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
library/std/src/sys/wasi/thread.rs
Outdated
| @@ -178,6 +179,17 @@ impl Thread { | |||
| } | |||
| } | |||
|
|
|||
| cfg_if::cfg_if! { | |||
There was a problem hiding this comment.
Is there a reason not to put this alongside the definition of Thread, i.e., in that same cfg_if?
There was a problem hiding this comment.
Moved it to the same cfg_if
g0djan
force-pushed
the
godjan/fix_114610
branch
from
cc48559
to
9b00e5f
Compare
programmerjake
approved these changes
Aug 16, 2023
|
@Mark-Simulacrum is there anything else to address? |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#114696 (Fix a pthread_t handle leak rust-lang#114610) - rust-lang#115102 (Improve note for the `invalid_reference_casting` lint) - rust-lang#115103 (Disable bootstrap rustc version check) - rust-lang#115106 (ArchiveWrapper: handle LLVM API update) - rust-lang#115109 (Skip ExpandYamlAnchors when the config is missing) - rust-lang#115135 (Rustdoc: Add unstable --no-html-source flag) r? `@ghost` `@rustbot` modify labels: rollup
wesleywiser
added
the
beta-nominated
|
Nominating for beta backport so that this fix can ride the release train with the |
rustbot
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
[beta] backports - Fix a pthread_t handle leak rust-lang#114696 - MCP661: Move wasm32-wasi-preview1-threads target to Tier 2 rust-lang#115345 - Don't modify libstd to dump rustc ICEs rust-lang#115627 - Paper over an accidental regression rust-lang#115844 - Update to LLVM 17.0.0 rust-lang#115959 r? cuviper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#114610
Ran the tests as described in https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-wasi-preview1-threads.md?plain=1#L125