Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #115137

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Rollup of 6 pull requests #115137

merged 15 commits into from
Aug 23, 2023

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

g0djan and others added 15 commits August 16, 2023 11:21
In llvm/llvm-project@f740bcb a boolean
parameter changed to an enum.

r? @nikic
@rustbot label: +llvm-main
The dist-src tarball does not include `.github/` at all, so we can't
check whether it needs to be regenerated.
…e, r=est31

Improve note for the `invalid_reference_casting` lint

This PR add link to the book interior mutability chapter, https://doc.rust-lang.org/book/ch15-05-interior-mutability.html; this is done to guide peoples to a place with many useful information and context.

*Note that this isn't the first occurrence of a link to the book in [tests outputs](https://github.com/search?q=repo%3Arust-lang%2Frust+book+path%3A%2F%5Etests%5C%2Fui%5C%2F%2F&type=code).*

r? `@est31`
…n_check, r=compiler-errors

Disable bootstrap rustc version check

Mitigates rust-lang#115065
… r=nikic

ArchiveWrapper: handle LLVM API update

In llvm/llvm-project@f740bcb a boolean parameter changed to an enum.

r? ``@nikic``
``@rustbot`` label: +llvm-main
Skip ExpandYamlAnchors when the config is missing

The dist-src tarball does not include `.github/` at all, so we can't
check whether it needs to be regenerated.
…, r=notriddle

Rustdoc: Add unstable --no-html-source flag

Fixes rust-lang#115060.

This is the equivalent of `#![doc(no_html_source)]` but on the command-line. It disables the generation of the source pages (and of the links pointing to them as well).

The motivation behind this is to enable to reduce documentation size when generating it in some locations without enforcing this to end users or adding a new feature to enable/disable the crate attribute.

r? `@notriddle`
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=6 rollup=never

@rustbot rustbot added O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 23, 2023
@bors
Copy link
Contributor

bors commented Aug 23, 2023

📌 Commit 5cbc00f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2023
@bors
Copy link
Contributor

bors commented Aug 23, 2023

⌛ Testing commit 5cbc00f with merge 8e8231f...

@bors
Copy link
Contributor

bors commented Aug 23, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 8e8231f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2023
@bors bors merged commit 8e8231f into rust-lang:master Aug 23, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#114696 Fix a pthread_t handle leak #114610 89d06a8cd02b37838c5327711cf1a8ece24877ca (link)
#115102 Improve note for the invalid_reference_casting lint e1353895164a9f0dfeb88a42149112b2b9698920 (link)
#115103 Disable bootstrap rustc version check 4d2290036ffb55a38c8082ca57bcd78ff1d24ae7 (link)
#115106 ArchiveWrapper: handle LLVM API update b5c7cc3662c423bcd59530ab8d7e1743f8de374e (link)
#115109 Skip ExpandYamlAnchors when the config is missing 3c552f337874adcc6c5b3824ad55ad6313477809 (link)
#115135 Rustdoc: Add unstable --no-html-source flag 40dda868d9a4c305c8b8320a5f3aacd4796b20cb (link)

previous master: 97fff1f2ed

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez GuillaumeGomez deleted the rollup-37jqoyg branch August 23, 2023 18:03
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8e8231f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.6% [1.1%, 2.5%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.534s -> 635.332s (0.13%)
Artifact size: 347.13 MiB -> 347.24 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-wasi Operating system: Wasi, Webassembly System Interface rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants