Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 1.72.1 release notes to master #115978

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

sksat
Copy link

@sksat sksat commented Sep 19, 2023

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Sep 19, 2023
RELEASES.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

Please squash the commits, and then I can approve.

update release date to actual released date
@sksat sksat force-pushed the copy-1.72.1-release-note-to-master branch from f21eb2d to ed3c63c Compare September 19, 2023 23:39
@sksat
Copy link
Author

sksat commented Sep 19, 2023

OK. squashed commits.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2023

📌 Commit ed3c63c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115965 (Add more if let guard tests)
 - rust-lang#115978 (Copy 1.72.1 release notes to master)
 - rust-lang#115983 (fix confusing let chain indentation in rustc_resolve)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 24fc098 into rust-lang:master Sep 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2023
Rollup merge of rust-lang#115978 - sksat:copy-1.72.1-release-note-to-master, r=Mark-Simulacrum

Copy 1.72.1 release notes to master

- rust-lang#115976
- this cherry-pick 1.72.1 release note from rust-lang#115787(0414f85)
@sksat sksat deleted the copy-1.72.1-release-note-to-master branch September 20, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants