fix confusing let chain indentation in rustc_resolve #115983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Comment on lines
992
to
993
| && let Some(max_vis) = max_vis.get() | ||
| && !max_vis.is_at_least(import.expect_vis(), self.tcx) |
There was a problem hiding this comment.
The correct style includes indenting the &&s. But not worth changing -- we'll be getting formatting for let-chains soon (rust-lang/rustfmt#5910)
Suggested change
| && let Some(max_vis) = max_vis.get() | |
| && !max_vis.is_at_least(import.expect_vis(), self.tcx) | |
| && let Some(max_vis) = max_vis.get() | |
| && !max_vis.is_at_least(import.expect_vis(), self.tcx) |
compiler-errors
approved these changes
Sep 19, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#115965 (Add more if let guard tests) - rust-lang#115978 (Copy 1.72.1 release notes to master) - rust-lang#115983 (fix confusing let chain indentation in rustc_resolve) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
Rollup merge of rust-lang#115983 - eopb:confusing-if-chain-indent, r=compiler-errors fix confusing let chain indentation in rustc_resolve Sorry for opening a PR for such a minor style fix. This just felt sufficiently misleading to warrant fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for opening a PR for such a minor style fix.
This just felt sufficiently misleading to warrant fixing.