speed up x clean
#117723
Merged
speed up x clean
#117723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
I think it will do whatever it was doing before but without purging bootstrap. |
Oh no. Wait. I am wrong actually. Let me fix that case. |
Since `x clean` runs with bootstrap, we can speed up this process by avoiding the cleaning of bootstrap artifacts, as they are not necessarily needed to be cleaned. Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
keep-bootstrap-on-x-clean
branch
from
90e5346
to
de0458a
Compare
Thanks for the call! @albertlarsan68 Now |
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 9, 2023
…an, r=albertlarsan68 speed up `x clean` Since `x clean` runs with bootstrap, we can speed up this process by avoiding the cleaning of bootstrap artifacts, as they are not necessarily needed to be cleaned. ref #rust-lang#117653 (comment)
This was referenced Nov 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#116762 (Fixup `Atomic*::from_ptr` safety docs) - rust-lang#117645 (Extend builtin/auto trait args with error when they have >1 argument) - rust-lang#117694 (Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io`) - rust-lang#117705 (triagebot.toml: use inclusive language) - rust-lang#117723 (speed up `x clean`) - rust-lang#117724 (Restore rustc shim error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2023
Rollup merge of rust-lang#117723 - onur-ozkan:keep-bootstrap-on-x-clean, r=albertlarsan68 speed up `x clean` Since `x clean` runs with bootstrap, we can speed up this process by avoiding the cleaning of bootstrap artifacts, as they are not necessarily needed to be cleaned. ref #rust-lang#117653 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
x cleanruns with bootstrap, we can speed up this process by avoiding the cleaning of bootstrap artifacts, as they are not necessarily needed to be cleaned.ref ##117653 (comment)