New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BorrowedBuf
and BorrowedCursor
from std:io
to core::io
#117694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Nov 8, 2023
This was referenced Nov 8, 2023
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
core-io-borrowed-buf
branch
from
November 8, 2023 00:26
c67267c
to
f643ed1
Compare
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
core-io-borrowed-buf
branch
from
November 8, 2023 00:34
f643ed1
to
0d82e21
Compare
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
core-io-borrowed-buf
branch
from
November 8, 2023 00:42
0d82e21
to
94eb6b0
Compare
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 8, 2023
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2023
…m-ou-se Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io` Tracking issue: rust-lang#117693 ACP: rust-lang/libs-team#290
☔ The latest upstream changes (presumably #115460) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 8, 2023
Assigned new feature name `core_io_borrowed_buf` to distinguish from the `Read::read_buf` functionality in `std::io`.
jmillikin
force-pushed
the
core-io-borrowed-buf
branch
from
November 8, 2023 22:11
94eb6b0
to
341c856
Compare
@bors retry |
@jmillikin: 🔑 Insufficient privileges: not in try users |
@bors r+ |
bors
removed
the
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 8, 2023
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Nov 8, 2023
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 9, 2023
…m-ou-se Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io` Tracking issue: rust-lang#117693 ACP: rust-lang/libs-team#290
This was referenced Nov 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#116762 (Fixup `Atomic*::from_ptr` safety docs) - rust-lang#117645 (Extend builtin/auto trait args with error when they have >1 argument) - rust-lang#117694 (Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io`) - rust-lang#117705 (triagebot.toml: use inclusive language) - rust-lang#117723 (speed up `x clean`) - rust-lang#117724 (Restore rustc shim error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2023
Rollup merge of rust-lang#117694 - jmillikin:core-io-borrowed-buf, r=m-ou-se Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io` Tracking issue: rust-lang#117693 ACP: rust-lang/libs-team#290
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Dec 22, 2023
* upgrade stable feature `return_position_impl_trait_in_trait` * upgrade lazy_cell rust-lang/rust/pull/105587 * upgrade core_io_borrowed_buf rust-lang/rust/pull/117694 * fix return position lifetime annotation Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #117693
ACP: rust-lang/libs-team#290