Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update target feature following LLVM API change #118610

Merged
merged 1 commit into from
Dec 9, 2023
Merged

update target feature following LLVM API change #118610

merged 1 commit into from
Dec 9, 2023

Conversation

krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Dec 4, 2023 •
edited

LLVM commit llvm/llvm-project@e817966 renamed* the unaligned-scalar-mem target feature to fast-unaligned-access.

(*) technically the commit folded two previous features into one, but there are no references to the other one in rust.

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2023
@krasimirgg
Copy link
Contributor Author

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Dec 4, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lqd
Copy link
Member

lqd commented Dec 4, 2023

Could you please add r? @ghost in the description to such draft PRs when opening them? That way the bot will not assign and ping a reviewer when there won't be a need for review.

(The same principle can be applied to regular PRs before asking for a specific reviewer that was not randomly picked)

@lqd lqd unassigned TaKO8Ki Dec 4, 2023
@krasimirgg
Copy link
Contributor Author

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2023

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@krasimirgg
Copy link
Contributor Author

Could you please add r? @ghost in the description to such draft PRs when opening them? That way the bot will not assign and ping a reviewer when there won't be a need for review.

(The same principle can be applied to regular PRs before asking for a specific reviewer that was not randomly picked)

Thank you! It appears that this somehow doesn't work for me, see me try in a comment closeby:

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@lqd
Copy link
Member

lqd commented Dec 4, 2023 •
edited

No worries! Note that it will work as I described if you add it in the PR description when you open it, but can't unfortunately be done after the fact.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
Copy link
Member

bjorn3 commented Dec 4, 2023

We should probably keep the old or the new name on the rust side and translate it as necessary when passing to/reading from LLVM depending on the LLVM version.

@nico nico mentioned this pull request Dec 5, 2023
Merged
@krasimirgg
Copy link
Contributor Author

We should probably keep the old or the new name on the rust side and translate it as necessary when passing to/reading from LLVM depending on the LLVM version.

done

@krasimirgg
Copy link
Contributor Author

r? @nikic

@krasimirgg krasimirgg marked this pull request as ready for review December 7, 2023 11:25
@krasimirgg krasimirgg changed the title [DO NOT MERGE] update target feature following LLVM API change update target feature following LLVM API change Dec 7, 2023
@nikic
Copy link
Contributor

nikic commented Dec 7, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 7, 2023

📌 Commit 0104620 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#118610 - krasimirgg:llvm-18-dec, r=nikic
78aedc7 
update target feature following LLVM API change

LLVM commit llvm/llvm-project@e817966 renamed* the `unaligned-scalar-mem` target feature to `fast-unaligned-access`.

(*) technically the commit folded two previous features into one, but there are no references to the other one in rust.
@klensy
Copy link
Contributor

klensy commented Dec 7, 2023

DO NOT MERGE commits should be removed :-)

@compiler-errors
Copy link
Member

@bors r-

Please rebase away the [DO NOT MERGE] commits.

Thanks @klensy for catching this.

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 7, 2023
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 7, 2023
@krasimirgg
update target feature following LLVM API change
b378059 
LLVM commit llvm/llvm-project@e817966
renamed the `unaligned-scalar-mem` target feature to `fast-unaligned-access`.
@krasimirgg
Copy link
Contributor Author

Removed the "do not submit" commits.

@nikic
Copy link
Contributor

nikic commented Dec 8, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 8, 2023

📌 Commit b378059 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2023
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Dec 9, 2023
@workingjubilee
Rollup merge of rust-lang#118610 - krasimirgg:llvm-18-dec, r=nikic
4d94018 
update target feature following LLVM API change

LLVM commit llvm/llvm-project@e817966 renamed* the `unaligned-scalar-mem` target feature to `fast-unaligned-access`.

(*) technically the commit folded two previous features into one, but there are no references to the other one in rust.
@workingjubilee workingjubilee mentioned this pull request Dec 9, 2023
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Dec 9, 2023
@workingjubilee
Rollup merge of rust-lang#118610 - krasimirgg:llvm-18-dec, r=nikic
34273dd 
update target feature following LLVM API change

LLVM commit llvm/llvm-project@e817966 renamed* the `unaligned-scalar-mem` target feature to `fast-unaligned-access`.

(*) technically the commit folded two previous features into one, but there are no references to the other one in rust.
@workingjubilee workingjubilee mentioned this pull request Dec 9, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
@bors
Auto merge of rust-lang#118768 - workingjubilee:rollup-tilil66, r=wor…
3deea35 
…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions)
 - rust-lang#118512 (Add tests related to normalization in implied bounds)
 - rust-lang#118610 (update target feature following LLVM API change)
 - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans)
 - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.)
 - rust-lang#118756 (use bold magenta instead of bold white for highlighting)
 - rust-lang#118762 (Some more minor `async gen`-related nits)
 - rust-lang#118764 (Make async generators fused by default)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Dec 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
@bors
Auto merge of rust-lang#118771 - workingjubilee:rollup-q1p3riz, r=wor…
ce67033 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions)
 - rust-lang#118512 (Add tests related to normalization in implied bounds)
 - rust-lang#118610 (update target feature following LLVM API change)
 - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans)
 - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.)
 - rust-lang#118762 (Some more minor `async gen`-related nits)
 - rust-lang#118764 (Make async generators fused by default)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 85c9de9 into rust-lang:master Dec 9, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 9, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
@rust-timer
Unrolled build for rust-lang#118610
6ca70ac 
Rollup merge of rust-lang#118610 - krasimirgg:llvm-18-dec, r=nikic

update target feature following LLVM API change

LLVM commit llvm/llvm-project@e817966 renamed* the `unaligned-scalar-mem` target feature to `fast-unaligned-access`.

(*) technically the commit folded two previous features into one, but there are no references to the other one in rust.
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 11, 2023
@nico
Revert "Cherry-pick a fix for a rustc change needed by trunk LLVM"
3c908a1 
This reverts commit 92c44e8.

Reason for revert:
rust-lang/rust#118610 landed upstream.

Original change's description:
> Cherry-pick a fix for a rustc change needed by trunk LLVM
>
> Bug: 1508414
> Change-Id: I5077183ec32d95b46768c7f1e40ff3bd1699f219
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5090348
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1234381}

Bug: 1508414
Change-Id: If650c473efe8327fff8f327b43c0423525515998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110439
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1235685}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikic nikic

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@krasimirgg @rustbot @rust-log-analyzer @lqd @bjorn3 @nikic @bors @klensy @compiler-errors @TaKO8Ki