Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tidy alphabetical checking to tests/. #118737

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Dec 8, 2023

This is desired for #118702.

r? @Nilstrieb

@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2023

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 8, 2023
@rustbot rustbot assigned Nilstrieb and unassigned onur-ozkan Dec 8, 2023
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change in #118702. Works as expected.

@Nilstrieb
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 8, 2023

📌 Commit 5d16c54 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 8, 2023
…estsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? ``@Nilstrieb``
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 8, 2023
…estsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? ```@Nilstrieb```
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 8, 2023
…estsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? ````@Nilstrieb````
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2023
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118150 (Add new targets {x86_64,i686}-win7-windows-msvc)
 - rust-lang#118417 (Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`.)
 - rust-lang#118692 (remove redundant imports)
 - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR)
 - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@nnethercote
Copy link
Contributor Author

@bors rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Dec 9, 2023
…estsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? `@Nilstrieb`
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Dec 9, 2023
…estsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? ``@Nilstrieb``
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions)
 - rust-lang#118512 (Add tests related to normalization in implied bounds)
 - rust-lang#118610 (update target feature following LLVM API change)
 - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans)
 - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.)
 - rust-lang#118756 (use bold magenta instead of bold white for highlighting)
 - rust-lang#118762 (Some more minor `async gen`-related nits)
 - rust-lang#118764 (Make async generators fused by default)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions)
 - rust-lang#118512 (Add tests related to normalization in implied bounds)
 - rust-lang#118610 (update target feature following LLVM API change)
 - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans)
 - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.)
 - rust-lang#118762 (Some more minor `async gen`-related nits)
 - rust-lang#118764 (Make async generators fused by default)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ad91141 into rust-lang:master Dec 9, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 9, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
Rollup merge of rust-lang#118737 - nnethercote:tidy-alphabetical-in-testsa, r=Nilstrieb

Extend tidy alphabetical checking to `tests/`.

This is desired for rust-lang#118702.

r? ```@Nilstrieb```
@nnethercote nnethercote deleted the tidy-alphabetical-in-testsa branch December 10, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants