Make inductive cycles in coherence ambiguous always #118649

compiler-errors · 2023-12-05T17:37:12Z

Logical conclusion of #114040
One step after #116493

cc rust-lang/trait-system-refactor-initiative#20

r? lcnr to kick off the FCP after review... maybe we should wait until 1.75 is landed? In that case, I'd still like to get the FCP boxes checked sooner since that'll be near the holidays which means everyone's away.

compiler-errors · 2023-12-05T17:45:27Z

tests/ui/coherence/warn-when-cycle-is-error-in-coherence.rs

 pub(crate) struct Interval<T>(PhantomData<T>);

 // This impl overlaps with the `derive` unless we reject the nested
 // `Interval<?1>: PartialOrd<Interval<?1>>` candidate which results
-// in a - currently inductive - cycle.


wait this comment can stay

why did you add another set of - here

bors · 2023-12-06T07:43:00Z

☔ The latest upstream changes (presumably #118655) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-12-07T21:28:18Z

☔ The latest upstream changes (presumably #118324) made this pull request unmergeable. Please resolve the merge conflicts.

lcnr · 2023-12-08T00:20:51Z

r=me after FCP

The coinductive_overlap_in_coherence lint has been deny by default and report now since #116493, which is part of 1.75 (which will be stabilized on the 2023.12.28)

I propose we change this lint to a hard error in version 1.77, which will be nightly starting from the 2023.12.22 and be stabilized on the 2024.03.21. This is a step towards coinductive traits and matches the existing behavior of -Ztrait-solver=next-coherence, which will probably also stabilize in 1.77 or 1.78. The original crater run resulted in a single regression: #114023 (comment). We opened an issue on the affected repo: kazatsuyu/interval-map#1. I do not believe this needs a separate crater run.

@rfcbot fcp merge

rfcbot · 2023-12-08T00:20:53Z

Team member @lcnr has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-12-08T18:44:03Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-12-18T18:44:31Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler-errors · 2023-12-18T18:54:09Z

This will be blocked until 1.77, which will be nightly starting later this month I think?

lcnr · 2023-12-19T06:18:02Z

the beta branch for 1.76 should happen on the 22nd. https://forge.rust-lang.org/#current-release-versions

compiler-errors · 2024-01-08T15:15:36Z

Beta has branched.

@bors r=lcnr

bors · 2024-01-08T15:15:39Z

📌 Commit 8abf133 has been approved by lcnr

It is now in the queue for this repository.

…=lcnr Make inductive cycles in coherence ambiguous always Logical conclusion of rust-lang#114040 One step after rust-lang#116493 cc rust-lang/trait-system-refactor-initiative#20 r? lcnr to kick off the FCP after review... maybe we should wait until 1.75 is landed? In that case, I'd still like to get the FCP boxes checked sooner since that'll be near the holidays which means everyone's away.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119562 (Rename `pointer` field on `Pin`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118649 - compiler-errors:coherence-ambig, r=lcnr Make inductive cycles in coherence ambiguous always Logical conclusion of rust-lang#114040 One step after rust-lang#116493 cc rust-lang/trait-system-refactor-initiative#20 r? lcnr to kick off the FCP after review... maybe we should wait until 1.75 is landed? In that case, I'd still like to get the FCP boxes checked sooner since that'll be near the holidays which means everyone's away.

error: lint `coinductive_overlap_in_coherence` has been removed: converted into hard error, see PR #118649 <rust-lang/rust#118649> for more information PR: 277786 Approved by: portmgr (build fix blanket)

Pkgsrc changes: * Adapt checksums and patches. Upstream chnages: Version 1.77.0 (2024-03-21) ========================== - [Reveal opaque types within the defining body for exhaustiveness checking.] (rust-lang/rust#116821) - [Stabilize C-string literals.] (rust-lang/rust#117472) - [Stabilize THIR unsafeck.] (rust-lang/rust#117673) - [Add lint `static_mut_refs` to warn on references to mutable statics.] (rust-lang/rust#117556) - [Support async recursive calls (as long as they have indirection).] (rust-lang/rust#117703) - [Undeprecate lint `unstable_features` and make use of it in the compiler.] (rust-lang/rust#118639) - [Make inductive cycles in coherence ambiguous always.] (rust-lang/rust#118649) - [Get rid of type-driven traversal in const-eval interning] (rust-lang/rust#119044), only as a [future compatiblity lint] (rust-lang/rust#122204) for now. - [Deny braced macro invocations in let-else.] (rust-lang/rust#119062) Compiler -------- - [Include lint `soft_unstable` in future breakage reports.] (rust-lang/rust#116274) - [Make `i128` and `u128` 16-byte aligned on x86-based targets.] (rust-lang/rust#116672) - [Use `--verbose` in diagnostic output.] (rust-lang/rust#119129) - [Improve spacing between printed tokens.] (rust-lang/rust#120227) - [Merge the `unused_tuple_struct_fields` lint into `dead_code`.] (rust-lang/rust#118297) - [Error on incorrect implied bounds in well-formedness check] (rust-lang/rust#118553), with a temporary exception for Bevy. - [Fix coverage instrumentation/reports for non-ASCII source code.] (rust-lang/rust#119033) - [Fix `fn`/`const` items implied bounds and well-formedness check.] (rust-lang/rust#120019) - [Promote `riscv32{im|imafc}-unknown-none-elf` targets to tier 2.] (rust-lang/rust#118704) - Add several new tier 3 targets: - [`aarch64-unknown-illumos`] (rust-lang/rust#112936) - [`hexagon-unknown-none-elf`] (rust-lang/rust#117601) - [`riscv32imafc-esp-espidf`] (rust-lang/rust#119738) - [`riscv32im-risc0-zkvm-elf`] (rust-lang/rust#117958) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Implement `From<&[T; N]>` for `Cow<[T]>`.] (rust-lang/rust#113489) - [Remove special-case handling of `vec.split_off (0)`.](rust-lang/rust#119917) Stabilized APIs --------------- - [`array::each_ref`] (https://doc.rust-lang.org/stable/std/primitive.array.html#method.each_ref) - [`array::each_mut`] (https://doc.rust-lang.org/stable/std/primitive.array.html#method.each_mut) - [`core::net`] (https://doc.rust-lang.org/stable/core/net/index.html) - [`f32::round_ties_even`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round_ties_even) - [`f64::round_ties_even`] (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round_ties_even) - [`mem::offset_of!`] (https://doc.rust-lang.org/stable/std/mem/macro.offset_of.html) - [`slice::first_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.first_chunk) - [`slice::first_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.first_chunk_mut) - [`slice::split_first_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_first_chunk) - [`slice::split_first_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_first_chunk_mut) - [`slice::last_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.last_chunk) - [`slice::last_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.last_chunk_mut) - [`slice::split_last_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_last_chunk) - [`slice::split_last_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_last_chunk_mut) - [`slice::chunk_by`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.chunk_by) - [`slice::chunk_by_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.chunk_by_mut) - [`Bound::map`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.map) - [`File::create_new`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.create_new) - [`Mutex::clear_poison`] (https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.clear_poison) - [`RwLock::clear_poison`] (https://doc.rust-lang.org/stable/std/sync/struct.RwLock.html#method.clear_poison) Cargo ----- - [Extend the build directive syntax with `cargo::`.] (rust-lang/cargo#12201) - [Stabilize metadata `id` format as `PackageIDSpec`.] (rust-lang/cargo#12914) - [Pull out as `cargo-util-schemas` as a crate.] (rust-lang/cargo#13178) - [Strip all debuginfo when debuginfo is not requested.] (rust-lang/cargo#13257) - [Inherit jobserver from env for all kinds of runners.] (rust-lang/cargo#12776) - [Deprecate rustc plugin support in cargo.] (rust-lang/cargo#13248) Rustdoc ----- - [Allows links in markdown headings.] (rust-lang/rust#117662) - [Search for tuples and unit by type with `()`.] (rust-lang/rust#118194) - [Clean up the source sidebar's hide button.] (rust-lang/rust#119066) - [Prevent JS injection from `localStorage`.] (rust-lang/rust#120250) Misc ---- - [Recommend version-sorting for all sorting in style guide.] (rust-lang/rust#115046) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add more weirdness to `weird-exprs.rs`.] (rust-lang/rust#119028)

rustbot assigned lcnr Dec 5, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2023

rust-cloud-vms bot force-pushed the coherence-ambig branch from b4f46dd to 7a4f862 Compare December 5, 2023 17:40

compiler-errors commented Dec 5, 2023

View reviewed changes

compiler-errors added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2023

rust-cloud-vms bot force-pushed the coherence-ambig branch from 7a4f862 to edae624 Compare December 7, 2023 16:33

This comment has been minimized.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 8, 2023

lcnr added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative label Dec 8, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 8, 2023

lcnr added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2023

lcnr mentioned this pull request Dec 18, 2023

Tracking issue for -Znext-solver=coherence (next solver enablement in coherence) #114862

Open

18 tasks

compiler-errors added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Dec 18, 2023

rust-cloud-vms bot force-pushed the coherence-ambig branch from edae624 to f4d63ab Compare December 18, 2023 18:54

apiraino removed the to-announce Announce this issue on triage meeting label Dec 28, 2023

Make inductive cycles in coherence ambiguous always

8abf133

rust-cloud-vms bot force-pushed the coherence-ambig branch from f4d63ab to 8abf133 Compare January 8, 2024 15:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jan 8, 2024

matthiaskrgr mentioned this pull request Jan 8, 2024

Rollup of 8 pull requests #119755

Closed

matthiaskrgr mentioned this pull request Jan 9, 2024

Rollup of 7 pull requests #119760

Merged

bors merged commit 1974f5c into rust-lang:master Jan 9, 2024
11 checks passed

rustbot added this to the 1.77.0 milestone Jan 9, 2024

lcnr mentioned this pull request Feb 9, 2024

Tracking Issue for coinductive_overlap_in_coherence lint #114040

Closed

3 tasks

This was referenced Mar 14, 2024

ambiguity on inductive cycles rust-lang/trait-system-refactor-initiative#20

Open

Make inductive cycles always ambiguous #122791

Merged

github-actions bot mentioned this pull request Apr 9, 2024

rust/1.77.2 package update wolfi-dev/os#16567

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make inductive cycles in coherence ambiguous always #118649

Make inductive cycles in coherence ambiguous always #118649

compiler-errors commented Dec 5, 2023

compiler-errors Dec 5, 2023

lcnr Dec 8, 2023

compiler-errors Dec 8, 2023

bors commented Dec 6, 2023

This comment has been minimized.

bors commented Dec 7, 2023

lcnr commented Dec 8, 2023 •

edited

rfcbot commented Dec 8, 2023 •

edited by spastorino

rfcbot commented Dec 8, 2023

rfcbot commented Dec 18, 2023

compiler-errors commented Dec 18, 2023

lcnr commented Dec 19, 2023

compiler-errors commented Jan 8, 2024

bors commented Jan 8, 2024

Make inductive cycles in coherence ambiguous always #118649

Make inductive cycles in coherence ambiguous always #118649

Conversation

compiler-errors commented Dec 5, 2023

compiler-errors Dec 5, 2023

Choose a reason for hiding this comment

lcnr Dec 8, 2023

Choose a reason for hiding this comment

compiler-errors Dec 8, 2023

Choose a reason for hiding this comment

bors commented Dec 6, 2023

This comment has been minimized.

bors commented Dec 7, 2023

lcnr commented Dec 8, 2023 • edited

rfcbot commented Dec 8, 2023 • edited by spastorino

rfcbot commented Dec 8, 2023

rfcbot commented Dec 18, 2023

compiler-errors commented Dec 18, 2023

lcnr commented Dec 19, 2023

compiler-errors commented Jan 8, 2024

bors commented Jan 8, 2024

lcnr commented Dec 8, 2023 •

edited

rfcbot commented Dec 8, 2023 •

edited by spastorino