New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: treat query string +
as space
#119327
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in GUI tests. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
a969dd2
to
624885d
Compare
@@ -279,7 +279,8 @@ function preLoadCss(cssUrl) { | |||
const params = {}; | |||
window.location.search.substring(1).split("&"). | |||
map(s => { | |||
const pair = s.split("="); | |||
// https://github.com/rust-lang/rust/issues/119219 | |||
const pair = s.split("=").map(x => x.replace(/\+/g, " ")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to this, I discovered that it was okay to use +
to replace a space in a query parameter but not in the path. So weird.
Thanks! @bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ca9ff83): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.752s -> 671.868s (-0.13%) |
Fixes #119219