Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ForeignItem as TAIT scope. #119420

Merged
merged 3 commits into from Jan 6, 2024
Merged

Handle ForeignItem as TAIT scope. #119420

merged 3 commits into from Jan 6, 2024

Conversation

cjgillot
Copy link
Contributor

Fixes #119295

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2023
compiler-errors
compiler-errors reviewed Dec 29, 2023
View reviewed changes
compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs Outdated
fn visit_foreign_item(&mut self, it: &'tcx hir::ForeignItem<'tcx>) {
trace!(?it.owner_id);
assert_ne!(it.owner_id.def_id, self.def_id);
self.check(it.owner_id.def_id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to call check here -- foreign items don't have typeck results?

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2024

📌 Commit 7fd2d8d has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#119420 - cjgillot:issue-119295, r=compiler-…
e8b5899 
…errors

Handle ForeignItem as TAIT scope.

Fixes rust-lang#119295
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#119420 - cjgillot:issue-119295, r=compiler-…
3f5d62b 
…errors

Handle ForeignItem as TAIT scope.

Fixes rust-lang#119295
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119604 - matthiaskrgr:rollup-vd0snqf, r=matth…
2076173 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint)
 - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues)
 - rust-lang#119420 (Handle ForeignItem as TAIT scope.)
 - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`)
 - rust-lang#119566 (Remove `-Zdump-mir-spanview`)
 - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.)
 - rust-lang#119577 (Migrate memory overlap check from validator to lint)
 - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature)
 - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table)

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 5, 2024
@GuillaumeGomez
Rollup merge of rust-lang#119420 - cjgillot:issue-119295, r=compiler-…
2dcaadb 
…errors

Handle ForeignItem as TAIT scope.

Fixes rust-lang#119295
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119611 - GuillaumeGomez:rollup-zbc4mc8, r=Gui…
2b7a8f9 
…llaumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues)
 - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo)
 - rust-lang#119420 (Handle ForeignItem as TAIT scope.)
 - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`)
 - rust-lang#119538 (Cleanup error handlers: round 5)
 - rust-lang#119566 (Remove `-Zdump-mir-spanview`)
 - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.)
 - rust-lang#119577 (Migrate memory overlap check from validator to lint)
 - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature)
 - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease
Copy link
Member

fmease commented Jan 5, 2024 •
edited

This has failed in rollup #119611 since the order of diagnostics has changed due to #117213.
Needs rebase & test reblessing.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2024
@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 5, 2024

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 5, 2024

📌 Commit eeaea57 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2024
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 6, 2024
@compiler-errors
Rollup merge of rust-lang#119420 - cjgillot:issue-119295, r=compiler-…
dc5b145 
…errors

Handle ForeignItem as TAIT scope.

Fixes rust-lang#119295
@compiler-errors compiler-errors mentioned this pull request Jan 6, 2024
Merged
@compiler-errors compiler-errors mentioned this pull request Jan 6, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2024
@bors
Auto merge of rust-lang#119648 - compiler-errors:rollup-42inxd8, r=co…
aa7e9f2 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119208 (coverage: Hoist some complex code out of the main span refinement loop)
 - rust-lang#119216 (Use diagnostic namespace in stdlib)
 - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo)
 - rust-lang#119420 (Handle ForeignItem as TAIT scope.)
 - rust-lang#119468 (rustdoc-search: tighter encoding for f index)
 - rust-lang#119628 (remove duplicate test)
 - rust-lang#119638 (fix cyle error when suggesting to use associated function instead of constructor)
 - rust-lang#119640 (library: Fix warnings in rtstartup)
 - rust-lang#119642 (library: Fix a symlink test failing on Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9585ebc into rust-lang:master Jan 6, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2024
@rust-timer
Unrolled build for rust-lang#119420
e1e94d4 
Rollup merge of rust-lang#119420 - cjgillot:issue-119295, r=compiler-errors

Handle ForeignItem as TAIT scope.

Fixes rust-lang#119295
@cjgillot cjgillot deleted the issue-119295 branch January 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

ICE: ForeignItem(ForeignItem ... is not a valid scope for an opaque type item
5 participants
@cjgillot @rustbot @compiler-errors @bors @fmease