Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics #117213

oli-obk · 2023-10-26T11:15:55Z

The first commit is just a cleanup.

The second commit moves most checks from check_mod_item_types into check_well_formed, invoking the checks in lockstep per-item instead of iterating over all items twice.

rustbot · 2023-10-26T11:16:05Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-10-26T11:39:07Z

I don't expect a perf effect, but technically some incremental cache dep graph could be affected

@bors try @rust-timer queue

bors · 2023-10-26T11:40:16Z

⌛ Trying commit 3cd5671 with merge 9eac8ba...

…try> Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics The first commit is just a cleanup. The second commit moves most checks from `check_mod_item_types` into `check_well_formed`, invoking the checks in lockstep per-item instead of iterating over all items twice.

bors · 2023-10-26T12:53:12Z

💔 Test failed - checks-actions

oli-obk · 2023-10-26T14:31:49Z

cc @rust-lang/rustdoc I had to revert some of #97842, as that only works if we avoid some sanity checks. We'll need to figure out a new way to get whatever was desired by that PR (though my changes did not affect any test output I think?)

oli-obk · 2023-10-26T14:37:27Z

@bors try @rust-timer queue

bors · 2023-10-26T14:38:37Z

⌛ Trying commit e1ec23b with merge df89a22...

…try> Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics The first commit is just a cleanup. The second commit moves most checks from `check_mod_item_types` into `check_well_formed`, invoking the checks in lockstep per-item instead of iterating over all items twice.

GuillaumeGomez · 2023-10-26T15:03:29Z

cc @notriddle as you are the author of #97842.

estebank

r=me

notriddle · 2023-10-26T17:02:25Z

@GuillaumeGomez

If it's necessary to make other cleanups on the compiler, reverting #97842 is acceptable. I'll make a follow-up PR to accomplish the same thing in a different way.

GuillaumeGomez · 2023-10-26T17:40:01Z

I'm not against it but you're the person who worked on it so just wanted you to be aware of it. :)

rustbot · 2023-10-27T12:21:42Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

oli-obk · 2024-01-03T11:24:13Z

The 1.4% regression must be noise, it is purely in codegen, and this PR does not affect codegen.

The other regressions are real, either in incremental cache loading or in wf-check. Surprising, so I'll dig into those.

oli-obk · 2024-01-03T14:32:14Z

The regression is because we actually need to do some work when ensureing a query:

1,854,992  ???:<rustc_query_system::dep_graph::graph::DepGraphData<rustc_middle::dep_graph::DepsType>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
  597,830  ???:_rjem_je_arena_cache_bin_fill_small
 -473,102  /build/glibc-wuryBv/glibc-2.31/string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:__memcpy_avx_unaligned_erms
  309,010  ???:do_rallocx
  277,039  ???:_rjem_je_arena_ralloc
  269,328  ???:_rjem_je_malloc_default
  224,251  ???:rustc_middle::ty::codec::encode_with_shorthand::<rustc_middle::query::on_disk_cache::CacheEncoder, rustc_middle::ty::Ty, <rustc_middle::query::on_disk_cache::CacheEncoder as rustc_type_ir::codec::TyEncoder>::type_shorthands>
  198,054  ???:_rjem_je_arena_ralloc_no_move
   94,215  ???:_rjem_je_tcache_alloc_small_hard
   91,732  /build/glibc-wuryBv/glibc-2.31/nptl/../nptl/pthread_mutex_trylock.c:pthread_mutex_trylock
   85,620  ???:_rjem_je_tcache_bin_flush_stashed
  -72,143  ???:rustc_query_impl::plumbing::encode_query_results::<rustc_query_impl::query_impl::typeck::QueryType>::{closure

oli-obk · 2024-01-03T14:32:58Z

@bors r=estebank

bors · 2024-01-03T14:33:01Z

📌 Commit 5b13dc7 has been approved by estebank

It is now in the queue for this repository.

bors · 2024-01-03T14:33:02Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2024-01-04T01:37:14Z

⌛ Testing commit 5b13dc7 with merge 627ca93...

…stebank Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics The first commit is just a cleanup. The second commit moves most checks from `check_mod_item_types` into `check_well_formed`, invoking the checks in lockstep per-item instead of iterating over all items twice.

bors · 2024-01-04T05:52:14Z

💥 Test timed out

rust-log-analyzer · 2024-01-04T05:54:51Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

oli-obk · 2024-01-04T13:18:49Z

@bors retry

bors · 2024-01-05T00:04:11Z

⌛ Testing commit 5b13dc7 with merge 791a53f...

bors · 2024-01-05T02:52:39Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 791a53f to master...

rust-timer · 2024-01-05T04:26:47Z

Finished benchmarking commit (791a53f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.4%]	7
Regressions ❌ (secondary)	0.8%	[0.2%, 2.3%]	5
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.3%, 0.4%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[1.2%, 4.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-4.3%, -0.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.353s -> 669.247s (-0.16%)
Artifact size: 311.08 MiB -> 311.06 MiB (-0.01%)

rustbot assigned wesleywiser Oct 26, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 26, 2023

oli-obk changed the title ~~Refactor check_item_type to work on LocalDefId instead of ItemId~~ Reorder check_item_type diagnostics so they occur next to the corresponding check_well_formed diagnostics Oct 26, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 26, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Oct 26, 2023

This comment has been minimized.

Sign in to view

oli-obk force-pushed the check_item_type_cleanup branch from e1ec23b to d87c513 Compare October 26, 2023 14:56

This comment has been minimized.

Sign in to view

estebank approved these changes Oct 26, 2023

View reviewed changes

notriddle approved these changes Oct 26, 2023

View reviewed changes

oli-obk force-pushed the check_item_type_cleanup branch from d87c513 to 1af53e4 Compare October 27, 2023 12:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 3, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2024

bors merged commit 791a53f into rust-lang:master Jan 5, 2024

rustbot added this to the 1.77.0 milestone Jan 5, 2024

This was referenced Jan 5, 2024

Stabilize THIR unsafeck #117673

Merged

Add REDUNDANT_LIFETIMES lint to detect lifetimes which are semantically redundant #118391

Merged

Normalize region obligation in lexical region resolution with next-gen solver #119101

Merged

oli-obk deleted the check_item_type_cleanup branch January 5, 2024 08:28

This was referenced Jan 5, 2024

Handle ForeignItem as TAIT scope. #119420

Merged

Use resolutions(()).effective_visiblities to avoid cycle errors in report_object_error #119506

Merged

Rollup of 10 pull requests #119611

Closed

matthiaskrgr mentioned this pull request Feb 3, 2024

ice: Unexpected type for constructor #120601

Closed

Reorder check_item_type diagnostics so they occur next to the corresponding check_well_formed diagnostics #117213

Reorder check_item_type diagnostics so they occur next to the corresponding check_well_formed diagnostics #117213

Uh oh!

Conversation

oli-obk commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 26, 2023

Uh oh!

oli-obk commented Oct 26, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 26, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 26, 2023

Uh oh!

oli-obk commented Oct 26, 2023

Uh oh!

oli-obk commented Oct 26, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 26, 2023

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Oct 26, 2023

Uh oh!

This comment has been minimized.

estebank left a comment

Choose a reason for hiding this comment

Uh oh!

notriddle commented Oct 26, 2023

Uh oh!

GuillaumeGomez commented Oct 26, 2023

Uh oh!

rustbot commented Oct 27, 2023

Uh oh!

oli-obk commented Jan 3, 2024

Uh oh!

oli-obk commented Jan 3, 2024

Uh oh!

oli-obk commented Jan 3, 2024

Uh oh!

bors commented Jan 3, 2024

Uh oh!

bors commented Jan 3, 2024

Uh oh!

bors commented Jan 4, 2024

Uh oh!

bors commented Jan 4, 2024

Uh oh!

rust-log-analyzer commented Jan 4, 2024

Uh oh!

oli-obk commented Jan 4, 2024

Uh oh!

bors commented Jan 5, 2024

Uh oh!

bors commented Jan 5, 2024

Uh oh!

rust-timer commented Jan 5, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics #117213

Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics #117213

oli-obk commented Oct 26, 2023 •

edited

Loading