Gate PR CI on clippy correctness lints

[Kobzol]

Implements part of rust-lang/compiler-team#709.

Note that x.py clippy compiler also checks the standard library, because it needs to be checked before the compiler. This happens even with x.py clippy --stage 0.

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

r=me when MCP is ready to go

[ChrisDenton]

Note that x.py clippy compiler also checks the standard library, because it needs to be checked before the compiler. This happens even with x.py clippy --stage 0.

As this affects libs too, should this be t-libs-nominated so it can be put on the agenda for discussion?

[tgross35]

Should lints use the cargo lints table rather than CI config? So it's easier to check the same flags locally.

[Kobzol]

I guess that eventually we could use it, but correctness is enabled by default in Clippy (AFAIK), so we don't need to do anything special. You still need to run x.py clippy locally to see the lints that would be caught on CI.

A benefit of cargo.lints could be that x.py clippy would only show you the exact things that would be errors on CI (possibly as warnings locally). But we would have to do e.g. something like this for that to work:

[lints.clippy]
all = { level = "allow", priority = -1 }
correctness = "deny"

We would probably have to set this for all crates in compiler though.

[Nilstrieb]

Needs #119449, which I've nominated.

[Kobzol]

#119449 has been merged, let's see if PR CI passes.

[Kobzol]

Looks like CI is green.

@rustbot ready

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 4a2939b has been approved by Mark-Simulacrum

It is now in the queue for this repository.