Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sys/thread for UEFI #120938

Merged
merged 1 commit into from Feb 13, 2024
Merged

Implement sys/thread for UEFI #120938

merged 1 commit into from Feb 13, 2024

Conversation

Ayush1325
Copy link
Contributor

Since UEFI has no concept of threads, most of this module can be ignored. However, implementing parts that make sense.

  • Implement sleep
  • Implement available_parallelism

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2024

r? @joshtriplett

rustbot has assigned @joshtriplett.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 11, 2024
@Nilstrieb
Copy link
Member

Josh has removed themselves in #120906
r? libs

@rustbot rustbot assigned cuviper and unassigned joshtriplett Feb 11, 2024
joboet
joboet approved these changes Feb 11, 2024
View reviewed changes
library/std/src/sys/pal/uefi/thread.rs Outdated Show resolved Hide resolved
@Ayush1325
Implement sys/thread for UEFI
af428db 
Since UEFI has no concept of threads, most of this module can be
ignored. However, implementing parts that make sense.

- Implement sleep
- Implement available_parallelism

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Nilstrieb
Copy link
Member

@bors r=joboet,Nilstrieb
UEFI is tier 2, so no detailed correctness review is required anyways, but this looks good now

@bors
Copy link
Contributor

bors commented Feb 11, 2024

📌 Commit af428db has been approved by joboet,Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#120938 - Ayush1325:uefi-thread, r=joboet,Ni…
7811a82 
…lstrieb

Implement sys/thread for UEFI

Since UEFI has no concept of threads, most of this module can be ignored. However, implementing parts that make sense.

- Implement sleep
- Implement available_parallelism
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2024
@bors
Auto merge of rust-lang#120984 - matthiaskrgr:rollup-tld0avy, r=matth…
bf9504b 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#118983 (Warn on references casting to bigger memory layout)
 - rust-lang#119451 (Gate PR CI on clippy correctness lints)
 - rust-lang#120273 (compiletest: few naive improvements)
 - rust-lang#120889 (Implement Instant for UEFI)
 - rust-lang#120938 (Implement sys/thread for UEFI)
 - rust-lang#120950 (Fix async closures in CTFE)
 - rust-lang#120958 (Dejargonize `subst`)
 - rust-lang#120965 (Add lahfsahf and prfchw target feature)
 - rust-lang#120970 (add another test for promoteds-in-static)
 - rust-lang#120979 (Update books)

Failed merges:

 - rust-lang#120973 (allow static_mut_ref in some tests that specifically test mutable statics)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors rollup=iffy
I suspect this may also unexpectedly fail just as #120889

@bors
Copy link
Contributor

bors commented Feb 13, 2024

⌛ Testing commit af428db with merge 09d73fa...

@bors
Copy link
Contributor

bors commented Feb 13, 2024

☀️ Test successful - checks-actions
Approved by: joboet,Nilstrieb
Pushing 09d73fa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2024
@bors bors merged commit 09d73fa into rust-lang:master Feb 13, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 13, 2024
@Ayush1325 Ayush1325 deleted the uefi-thread branch February 13, 2024 07:49
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (09d73fa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.665s -> 663.509s (0.13%)
Artifact size: 308.47 MiB -> 308.32 MiB (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

@joboet joboet joboet approved these changes

Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Ayush1325 @rustbot @Nilstrieb @bors @matthiaskrgr @rust-timer @joshtriplett @joboet @cuviper