Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #120187

Merged
merged 23 commits into from
Jan 21, 2024
Merged

Rollup of 8 pull requests #120187

merged 23 commits into from
Jan 21, 2024

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    27f419b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb349a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c7a5b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    6d17169 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Add Ipv6Addr::is_ipv4_mapped

    This change consists of cherry-picking the content from the original
    PR[1], which got closed due to inactivity, and applying the following
    changes:
    
    * Resolving merge conflicts (obviously)
    * Linked to to_ipv4_mapped instead of to_ipv4 in the documentation (seems
      more appropriate)
    * Added the must_use and rustc_const_unstable attributes the original
      didn't have
    
    I think it's a reasonably useful method.
    
    [1] rust-lang#86490
    CDirkx authored and jstasiak committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    605504c View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    70b0364 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. coverage: Add #[rustfmt::skip] to tests with non-standard formatting

    These tests deliberately use non-standard formatting, so that the line
    execution counts reported by `llvm-cov` reveal additional information about
    where code regions begin and end.
    Zalathar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f149442 View commit details
    Browse the repository at this point in the history
  2. coverage: Tweak individual tests to be unaffected by rustfmt

    Some of these tests use non-standard formatting that we can simulate by
    strategically adding `//` line comments.
    
    One contains `where` clauses that would be split across multiple lines, which
    we can keep on one line by moving the bounds to the generic type instead.
    Zalathar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1f9353a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. coverage: Format all remaining tests

    These tests can simply be reformatted as normal, because the resulting changes
    are unimportant.
    Zalathar committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    99797bb View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. fix(rust-analyzer): use new pkgid spec to compare

    Starting from cargo#13311, Cargo's compiler artifact message
    uses Package ID specification as package's identifier format.
    weihanglo committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9650c30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be9668d View commit details
    Browse the repository at this point in the history
  3. Extract process_constant.

    cjgillot committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b22742e View commit details
    Browse the repository at this point in the history
  4. Extract process_assign.

    cjgillot committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e72b2b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Remove Ty: Copy bound

    Nadrieril committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    796cdc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    606eeb8 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Rollup merge of rust-lang#116090 - rmehri01:strict_integer_ops, r=m-o…

    …u-se
    
    Implement strict integer operations that panic on overflow
    
    This PR implements the first part of the ACP for adding panic on overflow style arithmetic operations (rust-lang/libs-team#270), mentioned in rust-lang#116064.
    
    It adds the following operations on both signed and unsigned integers:
    
    - `strict_add`
    - `strict_sub`
    - `strict_mul`
    - `strict_div`
    - `strict_div_euclid`
    - `strict_rem`
    - `strict_rem_euclid`
    - `strict_neg`
    - `strict_shl`
    - `strict_shr`
    - `strict_pow`
    
    Additionally, signed integers have:
    
    - `strict_add_unsigned`
    - `strict_sub_unsigned`
    - `strict_abs`
    
    And unsigned integers have:
    
    - `strict_add_signed`
    
    The `div` and `rem` operations are the same as normal division and remainder but are added for completeness similar to the corresponding `wrapping_*` operations.
    
    I'm not sure if I missed any operations, I basically found them from the `wrapping_*` and `checked_*` operations on both integer types.
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    b661cd6 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#118811 - EbbDrop:is-sorted-by-bool, r=Mark-…

    …Simulacrum
    
    Use `bool` instead of `PartiolOrd` as return value of the comparison closure in `{slice,Iteraotr}::is_sorted_by`
    
    Changes the function signature of the closure given to `{slice,Iteraotr}::is_sorted_by` to return a `bool` instead of a `PartiolOrd` as suggested by the libs-api team here: rust-lang#53485 (comment).
    
    This means these functions now return true if the closure returns true for all the pairs of values.
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e8d1c2e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#119081 - jstasiak:is-ipv4-mapped, r=dtolnay

    Add Ipv6Addr::is_ipv4_mapped
    
    This change consists of cherry-picking the content from the original PR[1], which got closed due to inactivity, and applying the following changes:
    
    * Resolving merge conflicts (obviously)
    * Linked to to_ipv4_mapped instead of to_ipv4 in the documentation (seems more appropriate)
    * Added the must_use and rustc_const_unstable attributes the original didn't have
    
    I think it's a reasonably useful method to have.
    
    [1] rust-lang#86490
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    3cd378c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#119461 - cjgillot:jump-threading-interp, r=…

    …tmiasko
    
    Use an interpreter in MIR jump threading
    
    This allows to understand assignments of aggregate constants. This case appears more frequently with GVN promoting aggregates to constants.
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    203cc69 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#119996 - joboet:move_pal_os_str, r=ChrisDenton

    Move OS String implementation into `sys`
    
    Part of rust-lang#117276. The new structure is really useful here, since we can easily eliminate a number of ugly `#[path]`-based imports.
    
    In the future, it might be good to move the WTF-8 implementation directly to the OS string implementation, I cannot see it being used anywhere else. That is a story for another PR, however.
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a1b41a9 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120015 - Zalathar:format, r=dtolnay

    coverage: Format all coverage tests with `rustfmt`
    
    As suggested by <rust-lang#119984 (comment)>.
    
    Test files in `tests/` are normally ignored by `x fmt`, but sometimes those files end up being run through `rustfmt` anyway, either by `rust-analyzer` or by hand.
    
    When that happens, it's annoying to have to manually revert formatting changes that are unrelated to the actual changes being made. So it's helpful for the tests in the repository to already have standard formatting beforehand.
    
    However, there are several coverage tests that deliberately use non-standard formatting, so that line counts reveal more information about where code regions begin and end. In those cases, we can use `#[rustfmt::skip]` to prevent that code from being disturbed.
    
    ``@rustbot`` label +A-code-coverage
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e8678b1 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120027 - Nadrieril:remove-ty-copy-bound, r=…

    …compiler-errors
    
    pattern_analysis: Remove `Ty: Copy` bound
    
    To make it compatible with rust-analyzer's `Ty` which isn't `Copy` (it's an `Arc`).
    
    r? ``@compiler-errors``
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e7f3dc7 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120084 - weihanglo:pkgid-spec, r=Mark-Simul…

    …acrum
    
    fix(rust-analyzer): use new pkgid spec to compare
    
    Starting from rust-lang/cargo#13311, Cargo's compiler artifact message
    uses Package ID specification as package's identifier format.
    
    Zulip topic: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/proc-macro-test.20bootstrap.20and.20pkgid.20JSON
    
    cc `@ehuss`
    Nadrieril committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    01669d2 View commit details
    Browse the repository at this point in the history