Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match lowering: define a convenient struct #122221

Merged
merged 2 commits into from Mar 10, 2024
Merged

match lowering: define a convenient struct #122221

merged 2 commits into from Mar 10, 2024

Conversation

Nadrieril
Copy link
Member

Small refactor PR: bindings and ascriptions always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2024
oli-obk
oli-obk approved these changes Mar 9, 2024
View reviewed changes
compiler/rustc_mir_build/src/build/matches/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_build/src/build/matches/mod.rs Outdated
&& subcandidate.bindings.is_empty()
&& subcandidate.ascriptions.is_empty();
&& subcandidate.extra_data.bindings.is_empty()
&& subcandidate.extra_data.ascriptions.is_empty();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the future information you add here be similar to these two lists and checked here? If so, maybe a single is_empty method on the struct could be useful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout 👍

@Nadrieril
Copy link
Member Author

@bors r=@oli-obk rollup=always

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit 594cf1d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk
f31e4dc 
match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122260 - matthiaskrgr:rollup-ik8lga9, r=matth…
88de7b1 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#121561 (Detect typos for compiletest test directives)
 - rust-lang#121567 (Avoid some interning in bootstrap)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#121907 (skip sanity check for non-host targets in `check` builds)
 - rust-lang#122029 (When displaying multispans, ignore empty lines adjacent to `...`)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 10, 2024
@workingjubilee
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk
9e9fd65 
match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@workingjubilee workingjubilee mentioned this pull request Mar 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122265 - workingjubilee:rollup-3uuyc3w, r=wor…
74a8674 
…kingjubilee

Rollup of 10 pull requests

Successful merges:

 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#121561 (Detect typos for compiletest test directives)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)
 - rust-lang#122264 (add myself to rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk
5902d4e 
match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122273 - matthiaskrgr:rollup-cjnrh8i, r=matth…
e7cfe98 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)
 - rust-lang#122264 (add myself to rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk
06ade42 
match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 10, 2024
@jhpratt
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk
872e840 
match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@jhpratt jhpratt mentioned this pull request Mar 10, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122283 - matthiaskrgr:rollup-w3sau3u, r=matth…
cdb775c 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#121567 (Avoid some interning in bootstrap)
 - rust-lang#121642 (Update a test to support Symbol Mangling V0)
 - rust-lang#121685 (Fixing shellcheck comments on lvi test script)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#121942 (std::rand: enable getrandom for dragonflybsd too.)
 - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds)
 - rust-lang#122221 (match lowering: define a convenient struct)
 - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes)
 - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error)
 - rust-lang#122264 (add myself to rotation)
 - rust-lang#122269 (doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3)
 - rust-lang#122271 (Fix legacy numeric constant diag items)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 163573a into rust-lang:master Mar 10, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@rust-timer
Unrolled build for rust-lang#122221
048bd48 
Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk

match lowering: define a convenient struct

Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
@Nadrieril Nadrieril deleted the patextradata branch March 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nadrieril @rustbot @bors @oli-obk @TaKO8Ki