Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand ItemDecorator extensions in all contexts #12258

Closed
wants to merge 2 commits into from
Closed

Expand ItemDecorator extensions in all contexts #12258

wants to merge 2 commits into from

Commits on Feb 14, 2014

  1. Tweak ItemDecorator API 

    The old method of building up a list of items and threading it through
all of the decorators was unwieldy and not really scalable as
non-deriving ItemDecorators become possible. The API is now that the
decorator gets an immutable reference to the item it's attached to, and
a callback that it can pass new items to. If we want to add syntax
extensions that can modify the item they're attached to, we can add that
later, but I think it'll have to be separate from ItemDecorator to avoid
strange ordering issues.
    @sfackler
    sfackler committed Feb 14, 2014
    5 Configuration menu
    Copy the full SHA
    3c02749 View commit details
    Browse the repository at this point in the history

  2. Expand ItemDecorator extensions in all contexts 

    Now that fold_item can return multiple items, this is pretty trivial. It
also recursively expands generated items so ItemDecorators can generate
items that are tagged with ItemDecorators!

Closes rust-lang#4913
    @sfackler
    sfackler committed Feb 14, 2014
    Configuration menu
    Copy the full SHA
    907daa2 View commit details
    Browse the repository at this point in the history