Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build a broken/untested profiler runtime on mingw targets #122613

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Don't build a broken/untested profiler runtime on mingw targets #122613

merged 4 commits into from
Jun 15, 2024

Commits on Jun 14, 2024

  1. Use -Zno-profiler-runtime instead of //@ needs-profiler-support 

    For PGO/coverage tests that don't need to build or run an actual artifact, we
can use `-Zno-profiler-runtime` to run the test even when the profiler runtime
is not available.
    @Zalathar
    Zalathar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5330ccd View commit details
    Browse the repository at this point in the history

  2. Don't build a known-broken profiler runtime in x86_64-mingw

    @Zalathar
    Zalathar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3f3b8bb View commit details
    Browse the repository at this point in the history

  3. Remove //@ ignore-windows-gnu from tests that need the profiler 

    The profiler runtime is no longer built in mingw test jobs, so these tests
should naturally be skipped by `//@ needs-profiler-support`.
    @Zalathar
    Zalathar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2646db9 View commit details
    Browse the repository at this point in the history

  4. Remove broken/untested --enable-profiler from mingw dist builds

    @Zalathar
    Zalathar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    186d94d View commit details
    Browse the repository at this point in the history