-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use precompiled rustc for non-dist builders #122709
use precompiled rustc for non-dist builders #122709
Conversation
This comment has been minimized.
This comment has been minimized.
a080419
to
7a798d5
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts. |
7a8706a
to
7ca076d
Compare
This comment has been minimized.
This comment has been minimized.
7ca076d
to
359b0d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f581ad1
to
6f7cdd6
Compare
This comment has been minimized.
This comment has been minimized.
8306066
to
795d92b
Compare
This comment has been minimized.
This comment has been minimized.
d7edc43
to
7099a13
Compare
@bors try |
…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost
☀️ Try build successful - checks-actions |
7099a13
to
731c8eb
Compare
@bors try |
…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
We recently had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. Signed-off-by: onur-ozkan <work@onurozkan.dev>
fba9fa3
to
adcacca
Compare
@bors try |
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
☀️ Try build successful - checks-actions |
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
Rollup merge of rust-lang#129943 - onur-ozkan:test-float-parse-compiler, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
Rollup merge of rust-lang#129942 - onur-ozkan:building-rustc-tools, r=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple.
As we are going to make
rust.download-rustc=if-unchanged
default option with #119899, we need to make sureif-unchanged
logic never breaks and works as expected.As an addition, this will significantly improve the build times on CI when there's no change on the compiler.
blocker for #119899
try-job: aarch64-apple