use precompiled rustc for non-dist builders #122709
Closed
+178
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
a080419
to
7a798d5
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts. |
onur-ozkan
added
S-waiting-on-author
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
2 times, most recently
from
7a8706a
to
7ca076d
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
7ca076d
to
359b0d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
f581ad1
to
6f7cdd6
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-bootstrap
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
8306066
to
795d92b
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
2 times, most recently
from
d7edc43
to
7099a13
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2024
…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost
|
☀️ Try build successful - checks-actions |
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
7099a13
to
731c8eb
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2024
…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2024
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
We recently had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
use-precompiled-rustc-by-default
branch
from
fba9fa3
to
adcacca
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2024
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2024
…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple
|
☀️ Try build successful - checks-actions |
This was referenced Sep 3, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…er, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 6, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 6, 2024
…=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2024
Rollup merge of rust-lang#129943 - onur-ozkan:test-float-parse-compiler, r=Kobzol use the bootstrapped compiler for `test-float-parse` test Fixes rust-lang#122709 (comment). Blocker for rust-lang#122709
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2024
Rollup merge of rust-lang#129942 - onur-ozkan:building-rustc-tools, r=Kobzol copy rustc rustlib artifacts from ci-rustc We recently (since rust-lang#129311) had an issue because some rustlib files were missing (like: "error[E0463]: can't find crate for rustc_ast") when building tools that rely on rustc. This patch fixes that by copying those files as required. r? Kobzol Blocker for rust-lang#122709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple.
As we are going to make
rust.download-rustc=if-unchangeddefault option with #119899, we need to make sureif-unchangedlogic never breaks and works as expected.As an addition, this will significantly improve the build times on CI when there's no change on the compiler.
blocker for #119899
try-job: aarch64-apple