Rollup of 7 pull requests #123121
Merged
Rollup of 7 pull requests #123121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy change. @rustbot label: +llvm-main
Tweak variable names in the deadlock example to remove any potential confusion that the behavior is somehow shadowing-related.
…piler-errors match lowering: build the `Place` instead of keeping a `PlaceBuilder` around Outside of `MatchPair::new` we don't construct new places, so we don't need to keep a `PlaceBuilder` around. A bit annoyingly we have to store an `Option<Place>` even though it's never `None` after simplification, but the alternative would be to re-entangle `MatchPair` construction and simplification and I'd rather not do that.
…kingjubilee Unix: Support more platforms with `preadv` and `pwritev` - `aix`, `dragonfly` and `openbsd` with direct call - `watchos` with weak linkage cc rust-lang#89517
…bilee std library thread.rs: fix NetBSD code for ILP32 CPUs.
…ingjubilee `UnixStream`: override `read_buf` Split from rust-lang#122441 r? ``@workingjubilee``
…gjubilee RustWrapper: update call for llvm/llvm-project@44d037cc258dcf179d2c48… …c93996bb406ecd0fae Easy change. `@rustbot` label: +llvm-main
Implement `Vec::pop_if`
This PR adds `Vec::pop_if` to the public API, behind the `vec_pop_if` feature.
```rust
impl<T> Vec<T> {
pub fn pop_if<F>(&mut self, f: F) -> Option<T>
where F: FnOnce(&mut T) -> bool;
}
```
Tracking issue: rust-lang#122741
## Open questions
- [ ] Should the first unit test be split up?
- [ ] I don't see any guidance on ordering of methods in impl blocks, should I move the method elsewhere?
…ilee Update `RwLock` deadlock example to not use shadowing Tweak variable names in the deadlock example to remove any potential confusion that the behavior is somehow shadowing-related.
rustbot
added
O-unix
|
@bors r+ rollup=never p=7 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 435b525514 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (37f9798): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.407s -> 669.488s (-0.14%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Placeinstead of keeping aPlaceBuilderaround #122439 (match lowering: build thePlaceinstead of keeping aPlaceBuilderaround)preadvandpwritev#122880 (Unix: Support more platforms withpreadvandpwritev)UnixStream: overrideread_buf#123084 (UnixStream: overrideread_buf)Vec::pop_if#123107 (ImplementVec::pop_if)RwLockdeadlock example to not use shadowing #123118 (UpdateRwLockdeadlock example to not use shadowing)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup