Postfix match fixes #123394
Merged
Postfix match fixes #123394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in match checking cc @Nadrieril |
rustbot
added
S-waiting-on-review
Nadrieril
approved these changes
Apr 3, 2024
estebank
reviewed
Apr 3, 2024
estebank
reviewed
Apr 3, 2024
Comment on lines
+508
to
+512
| // This is horrendous, and we should deal with it by just | ||
| // stashing the span of the braces somewhere (like in the match source). | ||
| scrut.span.find_ancestor_in_same_ctxt(expr_span).and_then(|scrut_span| { | ||
| let sm = self.tcx.sess.source_map(); | ||
| let brace_span = sm.span_extend_to_next_char(scrut_span, '{', true); |
There was a problem hiding this comment.
I agree, we need to audit and remove every span_extend_to_next_char or leave a comment explaining what stopped us from doing so.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123209 (Add section to sanitizer doc for `-Zexternal-clangrt`) - rust-lang#123342 (x.py test: remove no-op --skip flag) - rust-lang#123382 (Assert `FnDef` kind) - rust-lang#123386 (Set `CARGO` instead of `PATH` for Rust Clippy) - rust-lang#123393 (rustc_ast: Update `P<T>` docs to reflect mutable status.) - rust-lang#123394 (Postfix match fixes) - rust-lang#123412 (Output URLs of CI artifacts to GitHub summary) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup merge of rust-lang#123394 - compiler-errors:postfix-match-fixes, r=estebank Postfix match fixes 1. Don't ice on `expr as Ty.match {}` 2. Fix the suggestion span for non-exhaustive matches to add `_ => todo!(),` Fixes rust-lang#123383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expr as Ty.match {}_ => todo!(),Fixes #123383