Add section to sanitizer doc for -Zexternal-clangrt
#123209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/doc/unstable-book/src/compiler-flags/sanitizer.md cc @rust-lang/project-exploit-mitigations, @rcvalle |
rustbot
added
PG-exploit-mitigations
|
r? michaelwoerister It's not clear to me why this wasn't documented. |
|
cc @chriswailes as well |
|
LGTM. |
|
Thanks for taking care of this. Sorry I didn't add the documentation when I landed the patch. |
ObsidianMinor
force-pushed
the
doc/external-clangrt
branch
from
fbe9fec
to
e17f00d
Compare
|
Wanted to add a small tidbit near the top with all the other flags to make sure it can't be missed. |
rcvalle
reviewed
Mar 29, 2024
ObsidianMinor
force-pushed
the
doc/external-clangrt
branch
from
e17f00d
to
e30025a
Compare
|
Thanks for the PR, @ObsidianMinor! I'm sorry, you wasted time due to the missing documentation. Would you mind also adding an |
ObsidianMinor
force-pushed
the
doc/external-clangrt
branch
from
e30025a
to
7e6da89
Compare
This comment has been minimized.
This comment has been minimized.
After spending a week looking for answers to how to do the very thing this flag lets me do, it felt appropriate to document it where I would've expected it to be.
ObsidianMinor
force-pushed
the
doc/external-clangrt
branch
from
7e6da89
to
382459e
Compare
|
Looks great -- thanks, @ObsidianMinor! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123209 (Add section to sanitizer doc for `-Zexternal-clangrt`) - rust-lang#123342 (x.py test: remove no-op --skip flag) - rust-lang#123382 (Assert `FnDef` kind) - rust-lang#123386 (Set `CARGO` instead of `PATH` for Rust Clippy) - rust-lang#123393 (rustc_ast: Update `P<T>` docs to reflect mutable status.) - rust-lang#123394 (Postfix match fixes) - rust-lang#123412 (Output URLs of CI artifacts to GitHub summary) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup merge of rust-lang#123209 - ObsidianMinor:doc/external-clangrt, r=michaelwoerister Add section to sanitizer doc for `-Zexternal-clangrt` After spending a week looking for answers to how to do the very thing this flag lets me do, it felt appropriate to document it where I would've expected it to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spending a week looking for answers to how to do the very thing this flag lets me do, it felt appropriate to document it where I would've expected it to be.