Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workproducts without object files. #124023

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Commits on Apr 16, 2024

  1. Allow workproducts without object files.

    This pull request partially reverts changes from e16c3b4
    
    Original motivation for this assert was described with "A WorkProduct without a saved file is useless"
    which was true at the time but now it is possible to have work products with other types of files
    (llvm-ir, asm, etc) and there are bugreports for this failure:
    
    For example: rust-lang#123695
    
    Fixes rust-lang#123234
    
    Now existing `assert` and `.unwrap_or_else` are unified into a single
    check that emits slightly more user friendly error message if an object
    files was meant to be produced but it's missing
    pacak committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a03aeca View commit details
    Browse the repository at this point in the history