Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: implement job skipping in Python matrix calculation #124327

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 24, 2024

This removes the step YAML anchor and the corresponding bash script.

Best reviewed commit-by-commit.

r? @pietroalbini

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 24, 2024
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit c59bc9a has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 24, 2024

@bors r-

(found an error in one of the commits)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 24, 2024

The code was skipping jobs before based on a job attribute, but the channel was defined in an environment variable. Since we don't use the bash script anymore, there's no need to define an env. var., so I turned the skipping env. var. into an attribute on a job.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 24, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2024
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit c36d78e has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
@Kobzol Kobzol mentioned this pull request Apr 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2024
CI: implement job skipping in Python matrix calculation

This removes the `step` YAML anchor and the corresponding bash script.

Best reviewed commit-by-commit.

r? ``@pietroalbini``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 25, 2024
CI: implement job skipping in Python matrix calculation

This removes the `step` YAML anchor and the corresponding bash script.

Best reviewed commit-by-commit.

r? ``@pietroalbini``
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124257 (Rewrite the `no-input-file.stderr` test in Rust and support diff)
 - rust-lang#124324 (Minor AST cleanups)
 - rust-lang#124327 (CI: implement job skipping in Python matrix calculation)
 - rust-lang#124345 (Enable `--check-cfg` by default in UI tests)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124257 (Rewrite the `no-input-file.stderr` test in Rust and support diff)
 - rust-lang#124324 (Minor AST cleanups)
 - rust-lang#124327 (CI: implement job skipping in Python matrix calculation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 036bf57 into rust-lang:master Apr 25, 2024
10 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
Rollup merge of rust-lang#124327 - Kobzol:ci-skip-jobs, r=pietroalbini

CI: implement job skipping in Python matrix calculation

This removes the `step` YAML anchor and the corresponding bash script.

Best reviewed commit-by-commit.

r? ```@pietroalbini```
@rustbot rustbot added this to the 1.79.0 milestone Apr 25, 2024
@Kobzol Kobzol deleted the ci-skip-jobs branch April 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants