add support to override lldb binary path for ./x test #124501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
VladimirMakaev
force-pushed
the
add-lldb-to-config-toml
branch
from
0aee267
to
d6b88a5
Compare
onur-ozkan
reviewed
May 4, 2024
onur-ozkan
added
S-waiting-on-author
|
This PR modifies If appropriate, please update |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#124501 (add support to override lldb binary path for ./x test) - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".) - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally) - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities) - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg) - rust-lang#124717 (Implement `do_not_recommend` in the new solver) - rust-lang#124718 (Record impl args in the proof tree) - rust-lang#124720 (interpret: Drop: always evaluate place) - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`) - rust-lang#124723 (Use correct Hermit links in The `rustc` Book) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
Rollup merge of rust-lang#124501 - VladimirMakaev:add-lldb-to-config-toml, r=Mark-Simulacrum add support to override lldb binary path for ./x test When running debuginfo tests I couldn't set custom build of lldb. The `src/bootstrap/src/core/build_steps/test.rs` has "lldb" hardcoded. I ended up hacking `src/bootstrap/src/core/build_steps/test.rs` just to get the tests running the way I wanted. Then I've found out that we can override `gdb` under [build] section. This PR enables the same for `lldb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running debuginfo tests I couldn't set custom build of lldb. The
src/bootstrap/src/core/build_steps/test.rshas "lldb" hardcoded. I ended up hackingsrc/bootstrap/src/core/build_steps/test.rsjust to get the tests running the way I wanted.Then I've found out that we can override
gdbunder [build] section. This PR enables the same forlldb