Rollup of 10 pull requests #124726
Merged
Rollup of 10 pull requests #124726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
We are now using Docker caching directly rather than downloading archives from S3, so it should not be needed. This should unblock reusing the cache locally.
This fixes building `std` for targets like `mipsel-unknown-netbsd`. If `c_long` is an `i64`, this conversion works with `Into`. But if it's an `i32`, this failed to convert a `u32` to an `i32`.
the Hermit team seems to have moved from `hermitcore` to `hermit-os` on GitHub. this change corrects the old links on its target page.
Both are renamed! Sorry for the initial incorrect commit, but this should correct it. 😄
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
…toml, r=Mark-Simulacrum add support to override lldb binary path for ./x test When running debuginfo tests I couldn't set custom build of lldb. The `src/bootstrap/src/core/build_steps/test.rs` has "lldb" hardcoded. I ended up hacking `src/bootstrap/src/core/build_steps/test.rs` just to get the tests running the way I wanted. Then I've found out that we can override `gdb` under [build] section. This PR enables the same for `lldb`
…ark-Simulacrum add a reference link to the comment of the "cc" and "cmake". Having a reference link provides more context for the problems of bumping cc and cmake.
…rk-Simulacrum Enable reusing CI Docker cache when running CI images locally When running a CI image locally, e.g. using `DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linux`, it can take a long time until the Docker image is built, which is annoying. Since we now use proper Docker caching on CI, it should be possible to just `docker pull` the prebuilt image to reuse the cache. We didn't want to do this on CI, since our caching key isn't perfect and it's possible that we can miss some changes, but I think that for local usage it is fine (we could introduce some env. var. to force disable the image download, if needed). r? `@Mark-Simulacrum`
…g, r=lcnr Only consider ambiguous goals when finding best obligation for ambiguities We don't care about ambiguous goals when reporting true errors, and vice versa for ambiguities. r? lcnr
…ostics, r=jieyouxu Update Cargo specific diagnostics in check-cfg This PR updates the Cargo specific diagnostics for check-cfg/`unexpected_cfgs` lint. Specifically it update to new url and use the double-column (instead of one) in the Cargo directive suggestion. `@rustbot` label +F-check-cfg cc `@weihanglo`
…ext-solver, r=lcnr Implement `do_not_recommend` in the new solver Put the test into `diagnostic_namespace` test folder even though it's not in the diagnostic namespace, because it should be soon. r? lcnr cc `@weiznich`
…r=lcnr Record impl args in the proof tree Weren't recording these since they went through a different infcx method r? lcnr
…r-errors interpret: Drop: always evaluate place That way we can also avoid dealing with `instantiate_from_frame_and_normalize_erasing_regions`.
…kingjubilee library/std: Fix build for NetBSD targets with 32-bit `c_long` This fixes building `std` for targets like `mipsel-unknown-netbsd`. If `c_long` is an `i64`, this conversion works with `Into`. But if it's an `i32`, this failed to convert a `u32` to an `i32`.
…ubilee Use correct Hermit links in The `rustc` Book As is, this documentation links to the old Hermit organization, `hermitcore`, which isn't used anymore. I've updated the links to point to the new organization. This PR also changes the incorrect "rusty loader" link to point to the new `hermit-rs-template` repo. (fixes rust-lang#124722)
rustbot
added
A-testsuite
rustbot
added
T-compiler
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: d568423a7a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 5, 2024
|
Finished benchmarking commit (e82c861): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.414s -> 675.389s (0.14%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
do_not_recommendin the new solver #124717 (Implementdo_not_recommendin the new solver)c_long#124721 (library/std: Fix build for NetBSD targets with 32-bitc_long)rustcBook #124723 (Use correct Hermit links in TherustcBook)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup