Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt a codegen test for llvm 19 #124519

Merged
merged 1 commit into from Apr 30, 2024
Merged

Conversation

krasimirgg
Copy link
Contributor

No functional changes intended.

Found by our experimental rust + LLVM @ HEAD bot:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/27747#018f2570-018c-4b12-9c5a-38cf81453683/957-965

@rustbot label: +llvm-main
r? @durin42

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Apr 29, 2024
@krasimirgg krasimirgg marked this pull request as ready for review April 29, 2024 14:29
@nikic
Copy link
Contributor

nikic commented Apr 30, 2024

Duplicated by #124543 (which I approved because I saw it first).

@maurer
Copy link
Contributor

maurer commented Apr 30, 2024

This is not a duplicate of #124543 . It fixes the same underlying issue, but on different tests. This change was already live on the LLVM integration test when I saw the other one and fixed it.

@nikic
Copy link
Contributor

nikic commented Apr 30, 2024

Oh, you're right. In that case...

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 30, 2024

📌 Commit 52ea73a has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124519 (adapt a codegen test for llvm 19)
 - rust-lang#124524 (Add StaticForeignItem and use it on ForeignItemKind)
 - rust-lang#124540 (Give proof tree visitors the ability to instantiate nested goals directly)
 - rust-lang#124543 (codegen tests: Tolerate `range()` qualifications in enum tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4c9f29 into rust-lang:master Apr 30, 2024
10 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Apr 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
Rollup merge of rust-lang#124519 - krasimirgg:test-ranges, r=nikic

adapt a codegen test for llvm 19

No functional changes intended.

Found by our experimental rust + LLVM @ HEAD bot:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/27747#018f2570-018c-4b12-9c5a-38cf81453683/957-965

`@rustbot` label: +llvm-main
r? `@durin42`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants