Add StaticForeignItem and use it on ForeignItemKind #124524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
reviewed
Apr 29, 2024
spastorino
force-pushed
the
make-foreign-static-use-struct
branch
from
cabf10d
to
9aba1e9
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2024
…truct, r=<try> Add StaticForeignItem and use it on ForeignItemKind This is in preparation for unsafe extern blocks that adds a safe variant for functions inside extern blocks. r? `@oli-obk` cc `@compiler-errors`
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
make-foreign-static-use-struct
branch
from
9aba1e9
to
7c10939
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
make-foreign-static-use-struct
branch
from
7c10939
to
329e0dd
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
make-foreign-static-use-struct
branch
from
329e0dd
to
81debc1
Compare
|
Changes to the size of AST and/or HIR nodes. cc @nnethercote |
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
make-foreign-static-use-struct
branch
from
81debc1
to
f06e0f7
Compare
|
r=me after perf is happy |
|
@rust-timer build 13c65c9 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (13c65c9): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.855s -> 673.206s (0.20%) |
rustbot
removed
the
S-waiting-on-perf
|
@bors r=oli-obk |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124519 (adapt a codegen test for llvm 19) - rust-lang#124524 (Add StaticForeignItem and use it on ForeignItemKind) - rust-lang#124540 (Give proof tree visitors the ability to instantiate nested goals directly) - rust-lang#124543 (codegen tests: Tolerate `range()` qualifications in enum tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2024
Rollup merge of rust-lang#124524 - spastorino:make-foreign-static-use-struct, r=oli-obk Add StaticForeignItem and use it on ForeignItemKind This is in preparation for unsafe extern blocks that adds a safe variant for functions inside extern blocks. r? `@oli-obk` cc `@compiler-errors`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 2, 2024
…-struct, r=oli-obk Add StaticForeignItem and use it on ForeignItemKind This is in preparation for unsafe extern blocks that adds a safe variant for functions inside extern blocks. r? `@oli-obk` cc `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for unsafe extern blocks that adds a safe variant for functions inside extern blocks.
r? @oli-obk
cc @compiler-errors