Prepare for private fields by default #13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See here for the RFC: https://github.com/rust-lang/rfcs/blob/master/active/0004-private-fields.md |
|
Looks good. Btw, if a change is meant for a specific RFC, I think the RFC should be mentioned in the commit message as well. For example, in OpenStack we use: |
This is a necessary change in preparation for switching the defaults as part of rust-lang#8122. RFC: 0004-private-fields
This change is in preparation for rust-lang#8122. Nothing is currently done with these visibility qualifiers, they are just parsed and accepted by the compiler. RFC: 0004-private-fields
|
Sounds like a good idea to be! It certainly makes searching for commits related to an RFC easy to find. |
bors
added a commit
that referenced
this pull request
Mar 26, 2014
This change prepares `rustc` to accept private fields by default. These changes will have to go through a snapshot before the rest of the changes can happen.
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Sep 6, 2022
…jonas-schievink feat: Add a "Unmerge match arm" assist to split or-patterns inside match expressions Fixes rust-lang#13072. The way I implemented it it leaves the `OrPat` in place even if there is only one pattern now but I don't think something will break because of that, and when more code will be typed we'll parse it again anyway. Removing it (but keeping the child pattern) is hard, I don't know how to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prepares
rustcto accept private fields by default. These changes will have to go through a snapshot before the rest of the changes can happen.