Basic debugging information support #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locks, along with source line information generation for individual instructions.
…caches are not conflated. Generate ast_map entries for object members and resource constructors and destructors.
|
Please run |
|
The extra llvm patch is no longer required as of 6637340. |
|
Passes now. Merged. |
|
I was just going to pull this, but I see Marijn beat me to it. Can't wait to try it out! |
Closed
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Resolved link formatting issue. * Fixed escaping of brackets. * Fixed intra dock links. * Fixed broken link to rustc_middle::ty::layout::LayoutCx. * More hyperlink formatting warning fixed. * Fixed typo in struct. Mismatched curly braces. * fixed links and brackets. * Added gh action to build docs automatically. * Added gh action to build docs automatically. * Moved docs check to regressions script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nmatsakis expressed interest in integrating even basic debugging support, and that's what this provides. The -g flag will produce source line correspondence output, allowing for stepping and breakpoints inside gdb. There's also an --xg (extra debugging) flag behind which the rest of the debugging support lies unfinished (ie. can't build rustc completely yet, but works on toy programs).
Some stats:
Requires the llvm patch that's sitting in brson's repository to allow rustc to finish building.