Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out more strbuf references #14481

Merged
merged 1 commit into from
May 29, 2014
Merged

Conversation

alexcrichton
Copy link
Member

  • Removes format_strbuf!()

@huonw
Copy link
Member

huonw commented May 28, 2014

I'm not keen on the Add impl for string. It seems to easily encourage inefficient/overallocating code since it doesn't reuse the allocation of its argument, meaning s = s + a is horrible (especially in a loop). (And I relatively often see code approximately equivalent to that.)

I would be very interested in waiting a little longer to see if not having it is just too unbearable.

(Also this addition on strings isn't even commutative, i.e. it flies in the face of mathematical convention for the + operator. :P )

@sfackler
Copy link
Member

Legit travis failures.

I'd also prefer to leave the Add impl out for now.

@alexcrichton
Copy link
Member Author

Moved Add to #14482

This was only ever a transitionary macro.
bors added a commit that referenced this pull request May 29, 2014
@bors bors closed this May 29, 2014
@bors bors merged commit 42aed6b into rust-lang:master May 29, 2014
@alexcrichton alexcrichton deleted the no-format-strbuf branch May 30, 2014 05:31
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
fix: Fix vscode project linking popup buttons being swapped

closes rust-lang/rust-analyzer#14480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants