test: Add tests for issue #12223, "drop allowed while active borrows #15310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… borrows still in scope". This issue was fixed by PR rust-lang#12828 and rust-lang#5781. All that was left was to add tests. Closes rust-lang#12223.
|
r? @brson |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
…-failure, r=Veykril Don't provide `add_missing_match_arms` assist when upmapping match arm list failed Fixes rust-lang#15310 We shouldn't provide the assist when we fail to find the original match arm list. Note that this PR will temporarily make the assist not applicable when attribute macro operates on the match expression in question, just like the case in rust-lang#15310, for most of the current stable toolchain users. This is because the sysroot-abi proc-macro-srv on the current stable [discards] spans for `Group` delimiters in some code paths, which the popular `proc-macro2` crate almost always calls, and it makes the identity of match arm list's brackets lost, leading to the upmapping failure. This has been fixed by rust-lang#14960, which will land in the next stable, 1.71. [discards]: https://github.com/rust-lang/rust/blob/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/src/tools/rust-analyzer/crates/proc-macro-srv/src/abis/abi_sysroot/ra_server.rs#L231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still in scope".
This issue was fixed by PR #12828 and #5781. All that was left was to
add tests.
Closes #12223.