note about ref patterns in pointer guide #16828
Conversation
| # Patterns and `ref` | ||
|
|
||
| When you're trying to `match` something that's stored in a pointer, you may | ||
| come across an error. Here's some code: |
There was a problem hiding this comment.
This initially came across as you were going to show an invalid case before the correct one, so it's kinda confusing as the user has no idea which error you're talking about.
Thoughts?
There was a problem hiding this comment.
Maybe a simple edit along the lines of "When you're trying to match something that's stored in a pointer, there may be a situation where using y directly isn't the best option available. Here's some code:" will do?
There was a problem hiding this comment.
I think it's the "here's some code" that isn't doing it. Perhaps something like, `Let's see how we can approach it better" or something like that so they know they're looking at the correct version, not the faulty one.
I like the rest of @MatejLach's suggestion, though.
steveklabnik
force-pushed
the
more_pointer_guide
branch
from
e83d91f
to
7e4a145
Compare
|
Thanks everyone! Took those suggestions into account. What do you think now? |
|
Much better :) |
Fixes #13602