librustc: Forbid inherent implementations that aren't adjacent to the #17163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of the |
pcwalton
force-pushed
the
impls-next-to-struct
branch
from
f63cbb3
to
3234673
Compare
|
Updated. re-r? @alexcrichton |
pcwalton
force-pushed
the
impls-next-to-struct
branch
from
3234673
to
bfee958
Compare
|
Updated again. re-r? @alexcrichton |
pcwalton
force-pushed
the
impls-next-to-struct
branch
from
bfee958
to
b4049f4
Compare
type they provide an implementation for.
This breaks code like:
mod foo {
struct Foo { ... }
}
impl foo::Foo {
...
}
Change this code to:
mod foo {
struct Foo { ... }
impl Foo {
...
}
}
Additionally, if you used the I/O path extension methods `stat`,
`lstat`, `exists`, `is_file`, or `is_dir`, note that these methods have
been moved to the the `std::io::fs::PathExtensions` trait. This breaks
code like:
fn is_it_there() -> bool {
Path::new("/foo/bar/baz").exists()
}
Change this code to:
use std::io::fs::PathExtensions;
fn is_it_there() -> bool {
Path::new("/foo/bar/baz").exists()
}
Closes rust-lang#17059.
RFC rust-lang#155.
[breaking-change]
pcwalton
force-pushed
the
impls-next-to-struct
branch
from
b4049f4
to
467bea0
Compare
This was referenced Sep 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type they provide an implementation for.
This breaks code like:
Change this code to:
Closes #17059.
RFC #155.
[breaking-change]
r? @brson