Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core::str) changes to find / find_bytes #1831

Merged
merged 6 commits into from
Feb 14, 2012
Merged

(core::str) changes to find / find_bytes #1831

merged 6 commits into from
Feb 14, 2012

Conversation

killerswan
Copy link
Contributor

As a result of these commits:

  • starts_with will use slice_bytes to be a little bit faster
  • the b2c_pos (to convert byte positions to character positions) will be added
  • find and find_bytes return option types with char and byte positions, respectively

brson added a commit that referenced this pull request Feb 14, 2012
@brson
Merge pull request #1831 from killerswan/str_fixes
acabd82 
(core::str) changes to find / find_bytes
@brson brson merged commit acabd82 into rust-lang:master Feb 14, 2012
@brson
Copy link
Contributor

brson commented Feb 14, 2012

Thanks!

celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
@celinval
Move common arguments to their own structure (rust-lang#2449)
ef1358d 
This is a pre-work needed for implementing rust-lang#2440 as a subcommand. Today, the only other subcommand we have is assess and the way it takes arguments is rather broken as explained in rust-lang#1831.

For the playback sub-command, I expect that we will need at least CargoArgs and CommonArgs to control the build process and to control the process verbosity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@killerswan @brson