Implement higher-ranked trait bounds. #18993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
hrtb-5
branch
2 times, most recently
from
b4b15dd
to
2610c3d
Compare
|
A monumental effort! ⛄ |
nikomatsakis
force-pushed
the
hrtb-5
branch
3 times, most recently
from
98f1180
to
85cb01b
Compare
|
Addressed comments in 98f1180, now rebasing. |
|
Using p=1 due to the importance of this feature for 1.0 |
nikomatsakis
force-pushed
the
hrtb-5
branch
2 times, most recently
from
3bdfb1d
to
7dfdc6c
Compare
Consolidate the `unboxed_closure_sugar` and `unboxed_closure` feature gates.
…_ranked` module. Also moves the docs to a more suitable place.
something other than a trait type.
`Box<for<'a> Foo<&'a T> + 'a>` can be accepted. Also cleanup the visitor/fold in general, exposing more callbacks.
use simple pattern matching to take a guess at what the method's self category is in astconv, and check it more thoroughly later.
region binding at the impl site, so for method types that come from impls, it is necessary to liberate/instantiate late-bound regions at multiple depths.
…, add new tests relating to HRTB, consolidate the `unboxed_closures` and `overloaded_calls` feature gates.
bors
added a commit
that referenced
this pull request
Nov 18, 2014
Enough said. Fixes #18639. r? @pcwalton (or someone else?) This is a [breaking-change]. In particular, several feature gates related to unboxed closures were consolidated into one (`overloaded_calls`, `unboxed_closure_sugar` => `unboxed_closures`). Otherwise, I think everything that worked before should still work. File a bug and cc @nikomatsakis if you find otherwise. :)
This was referenced Nov 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough said.
Fixes #18639.
r? @pcwalton (or someone else?)
This is a [breaking-change]. In particular, several feature gates related to unboxed closures were consolidated into one (
overloaded_calls,unboxed_closure_sugar=>unboxed_closures). Otherwise, I think everything that worked before should still work. File a bug and cc @nikomatsakis if you find otherwise. :)