Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet #19955

Merged
merged 3 commits into from
Dec 19, 2014

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Dec 17, 2014

EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.

Should not be merged until rust-lang/rfcs#509 is accepted.

All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/

[breaking-change]

r? @aturon @alexcrichton

@Gankra Gankra changed the title Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCachu and EnumSet Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet Dec 17, 2014
@killercup
Copy link
Member

@gankro I just noticed there are some FIXMEs with refs of rust issue numbers in here (e.g. here). Should those issues be closed or moved to the new repo?

@Gankra
Copy link
Contributor Author

Gankra commented Dec 17, 2014

Those are almost all general language issues, in my experience. e.g. the linked issue (#5244) is just that Variants and [elem, ..n] notation don't play well. We don't log many issues for specific collection flaws. I will update #8009, though.

@alexcrichton
Copy link
Member

This looks great, thanks @gankro!

@aturon
Copy link
Member

aturon commented Dec 18, 2014

@gankro r=me after rebase/squash

@Gankra Gankra force-pushed the kill-all-code branch 2 times, most recently from 9e9768a to 7cb02a7 Compare December 18, 2014 19:05
bors added a commit that referenced this pull request Dec 19, 2014
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.

Should not be merged until rust-lang/rfcs#509 is accepted.

All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/

[breaking-change]

r? @aturon @alexcrichton
@bors bors merged commit 67d3823 into rust-lang:master Dec 19, 2014
@tbu-
Copy link
Contributor

tbu- commented Dec 25, 2014

@gankro You write "Kill EnumSet", but it's still there?

@Gankra
Copy link
Contributor Author

Gankra commented Dec 28, 2014

@tbu- It's not in std anymore; only libcollections.

@pnkfelix
Copy link
Member

pnkfelix commented Sep 11, 2018

Hmm I think this PR accidentally destroyed the special \r\n characters that were here:

fn main() {assert_eq!(b"", b"\
");
assert_eq!(b"\n", b"

This breaks the regression testing that we would want for #16278

(I only happened to notice their absence because I was wondering why this file was listed here:)

issue-16278.rs -text

kennytm added a commit to kennytm/rust that referenced this pull request Sep 12, 2018
…278, r=wesleywiser

Recover proper regression test for issue rust-lang#16278.

Spawned from my note rust-lang#19955 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants